Repository navigation
Incorrect caret position with complex scripts #118403
Description
Steps to Reproduce
- Execute
flutter runon the code sample on a platform with HW keyboard - Traverse the text using arrow left/right keys
Expected results: Caret advances correctly
Actual results: Caret jumps back and forth
Code sample
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(primarySwatch: Colors.blue),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
Widget build(BuildContext context) {
const TextStyle style = TextStyle(fontSize: 16.0);
return Scaffold(
appBar: AppBar(title: Text(widget.title)),
body: Center(
child: Column(
children: <Widget>[
const SizedBox(height: 100.0),
TextField(controller: TextEditingController(text: 'प्राप्त वर्णन प्रव्रुति')),
const SizedBox(height: 100.0),
],
),
),
);
}
}Logs
% flutter --version
Flutter 3.7.0-20.0.pre.6 • channel master • https://github.com/flutter/flutter.git
Framework • revision f8628b5cb1 (15 hours ago) • 2023-01-11 18:48:03 -0800
Engine • revision 4a8d6866a1
Tools • Dart 3.0.0 (build 3.0.0-112.0.dev) • DevTools 2.20.0
Metadata
Metadata
Assignees
Labels
Important issues not at the top of the work listRunning on desktopSupporting other languages or locales. (aka i18n)Entering text in a text field or keyboard related problemsFound to occur in 3.3Found to occur in 3.7flutter/packages/flutter repository. See also f: labels.The issue has been confirmed reproducible and is ready to work onmaterial_ui package in flutter/packagesIssue is closed as already fixed in a newer version
Activity
huycozy commentedon Jan 13, 2023
Hi @tgucio, thanks for filing the issue. I also can reproduce this on the latest
stableandmasterchannels.On the Web, it seems better even though the cursor doesn't move one step when moving to the space character between words.
This issue makes me remember the old issue that I have reproduced before: #106472. These issues seem to be similar since the it looks better on Web and they are all about cursor traversal (but they are different languages)
flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.10, on macOS 13.0.1 22A400 darwin-x64, locale en-VN) • Flutter version 3.3.10 on channel stable at /Users/huynq/Documents/GitHub/flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision 135454af32 (13 hours ago), 2022-12-15 07:36:55 -0800 • Engine revision 3316dd8728 • Dart version 2.18.6 • DevTools version 2.15.0 [✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0) • Android SDK at /Users/huynq/Library/Android/sdk • Platform android-33, build-tools 31.0.0 • ANDROID_HOME = /Users/huynq/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 14.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 14B47b • CocoaPods version 1.11.3 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2021.3) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) [✓] IntelliJ IDEA Community Edition (version 2022.1.1) • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart [✓] VS Code (version 1.73.1) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.54.0 [✓] Connected device (3 available) • SM T225 (mobile) • R9JT3004VRJ • android-arm64 • Android 12 (API 31) • macOS (desktop) • macos • darwin-x64 • macOS 13.0.1 22A400 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 108.0.5359.124 [✓] HTTP Host Availability • All required HTTP hosts are available • No issues found!tgucio commentedon Jan 13, 2023
Thanks @huycozy. I think they're actually different issues. This one, I believe, has to do with incorrect calcs when text shaping is used (either standard rules for Indic scripts or GSUB, GPOS in fonts). #106472 has to do with incorrect word boundaries, seen with Han script which normally doesn't use text shaping.
gspencergoog commentedon Jan 19, 2023
cc @jason-simmons @justinmc
justinmc commentedon Jan 19, 2023
Is this a duplicate of #118566? That issue may have a fix in progress in Skia.
tgucio commentedon Jan 19, 2023
@justinmc I don't think so: the Skia fix appears to be specific to RTL runs. Here it's LTR and my bet is that it has to do with what happens when the text shaper substitutes glyphs.
Fix out-of-bounds and reversed TextBox queries in computing caret met…
github-actions commentedon Apr 11, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.