Repository navigation
Proposal to add margin to MaterialBanner constructor #118704
Description
Use case
I would like to put an outer margin on the material banner.
Line 296 - 297:
Widget materialBanner = Container(
margin: EdgeInsets.only(bottom: elevation > 0 ? 10.0 : 0.0),
For example:
const MaterialBanner({
super.key,
required this.content,
this.contentTextStyle,
required this.actions,
this.elevation,
--> this.margin
Proposal
The goal is to get the Material banner with outer margin to get the design like this:
Activity
darshankawar commentedon Jan 19, 2023
@HELL-i
There's already a
marginproperty as I see here:flutter/packages/flutter/lib/src/material/banner.dart
Line 340 in d53cc4a
Can you try to make use of that and see if it helps in your case ?
HELL-i commentedon Jan 19, 2023
@darshankawar
THX, but i want to set a margin around the material banner and not only at the bottom this can done over the elevation.
The constructor not including the margin to override it at line 340.
flutter/packages/flutter/lib/src/material/banner.dart
Line 97 in d53cc4a
darshankawar commentedon Jan 19, 2023
I see, thanks for the insight. I'll treat this as a proposal to add
margintoMaterialBannerwidget.[-]MaterialBanner set outer margin[/-][+]Proposal to add `margin` to MaterialBanner constructor[/+]HELL-i commentedon Jan 19, 2023
THX
HansMuller commentedon Jan 19, 2023
The seems like a reasonable feature to add, so long as the defaults don't change. @HELL-i - would be interested in contributing a PR that adds this features (and tests it)?
hasnentai commentedon Jan 23, 2023
@HansMuller @darshankawar I would like to work on this issue
HELL-i commentedon Jan 23, 2023
@hasnentai @HansMuller
Here is a possible solution: master...HELL-i:flutter:master
hasnentai commentedon Jan 23, 2023
@HELL-i Cool I think this looks fine. Thanks for the update
HELL-i commentedon Jan 23, 2023
@hasnentai When i have time i will add widget tests and then i will create the PR.
hasnentai commentedon Jan 23, 2023
@HELL-i I added the changes along with Widget Test. Additionally, I also added a margin in
withAnimationmethod and Raised the PR #119005cc: @Piinks @shihaohong
github-actions commentedon Mar 3, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.