Skip to content

[pigeon] Obj-C generates function that is never used #119342

Description

@stuartmorgan-g

See flutter-team-archive/plugins#4803 (comment) for context; originally I thought this was a case where we needed to dynamically generate the function based on specifics of the API, but it turns out that it's always unused (which means I guess I don't have warnings-as-errors turned on for ObjC like I thought I had done; I must be misremembering which languages I've done it for).

GetNullableObject was used when classes were serialized as dictionaries, but now we only use GetNullableObjectAtIndex. The only references to GetNullableObject( anywhere in the generator is where it's generated, so we can just remove it.

Activity

  1. added
    c: regressionIt was better in the past than it is now
    packageflutter/packages repository. See also p: labels.
    p: pigeonrelated to pigeon messaging codegen tool
    P1High-priority issues at the top of the work list
    on Jan 27, 2023
  2. github-actions commented on Mar 3, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: regressionIt was better in the past than it is nowp: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions