Skip to content

[camera_android] Bump robolectric version to allow configurations for SDK >= 31 #119752

Description

@camsim99

The current robolectric version (4.5) used for the Android camera plugin does not support configuring tests to run on >= SDK 31. However, there are a number of tests in the plugin that configure tests this way, e.g. ResolutionFeatureTest.java. The robolectric version should be bumped to allow these tests to run.

Having tried to bump it experimentally, I know that this causes errors concerning unsupported Mockito operations, and these will have to be fixed as well to land the bump.

Dependabot may try to bump this version and create a PR, to which this issue should be linked.

Activity

  1. added
    P1High-priority issues at the top of the work list
    on Feb 2, 2023
  2. removed
    P2Important issues not at the top of the work list
    on Feb 2, 2023
  3. gmackall commented on Jun 16, 2023

    @gmackall
    Member

    @camsim99 this can be closed now that flutter/packages#4018 has landed, right?

    Does the body of the pr have to have specific wording to cause the issue to autoclose when the PR lands?

  4. camsim99 commented on Jun 20, 2023

    @camsim99
    ContributorAuthor

    @camsim99 this can be closed now that flutter/packages#4018 has landed, right?

    Does the body of the pr have to have specific wording to cause the issue to autoclose when the PR lands?

    Oh yes it needed "fixes <issue_number>"! You're right though, let's close this!

  5. github-actions commented on Jul 4, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listp: cameraThe camera pluginpackageflutter/packages repository. See also p: labels.platform-androidAndroid applications specifically

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions