Skip to content

Fix slow post-submit tests due to Dashing #120901

Description

@loic-sharma

The Dashing docs builds caused timeout issues as they exceeded 60 minutes. As a short-term workaround, we increased the timeouts to 90 minutes (#120718, #120899).

Long-term solutions:

  1. Make Linux docs_test not generate the docset in post-submit. This is redundant with Linux docs_publish.
  2. Additionally, consider...
    1. Contribute performance improvements to Dashing
    2. Determine if offline docset is needed. If not, remove Dashing from Linux docs_test and Linux docs_publish
    3. Move docs build to GitHub Actions (similar to the coverage build)
    4. Marking docs build targets as bringup

Related: #115945

Activity

  1. changed the title [-]Improve the performance of Dashing docs build[/-] [+]Fix slow post-submit tests due to Dashing[/+] on Feb 17, 2023
  2. added
    a: tests"flutter test", flutter_test, or one of our tests
    and removed
    team-infraOwned by Infrastructure team
    on Nov 2, 2023
  3. Hixie commented on Nov 14, 2023

    @Hixie
    Contributor

    It's not clear exactly what this shard does (it just says "name: Linux docs_publish", "recipe: flutter/flutter", but I don't know what to do with that; when I followed the breadcrumbs I got to https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/flutter/flutter.py which does not mention docs at all).

    Could we get more information on how this is configured and so forth so that whoever wants to debug this problem knows where to start?

  4. added
    fyi-infraFor the attention of Infrastructure team
    on Nov 14, 2023
  5. Hixie commented on Nov 14, 2023

    @Hixie
    Contributor

    Looking at the Flutter dashboard, it looks like these shards now take <30 minutes, FWIW. Maybe this is a non-issue now?

  6. goderbauer commented on Dec 5, 2023

    @goderbauer
    Member

    Closing this since it continues to not be an issue anymore.

  7. Hixie commented on Dec 6, 2023

    @Hixie
    Contributor

    well we do need to reduce the timeout

  8. reopened this on Dec 6, 2023
  9. self-assigned this
    on Dec 6, 2023
  10. keyonghan commented on Dec 7, 2023

    @keyonghan
    Contributor
  11. added
    P2Important issues not at the top of the work list
    triaged-infraTriaged by Infrastructure team
    on Dec 7, 2023
  12. github-actions commented on Feb 14, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  13. locked as resolved and limited conversation to collaborators on Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: tech-debtTechnical debt, code quality, testing, etc.waiting for PR to land (fixed)A fix is in flightwill need additional triageThis issue or PR needs attention before being routed to secondary triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions