Skip to content

Extract a 'routes table' type Navigator wrapper #12108

Closed
Closed
Extract a 'routes table' type Navigator wrapper#12108
Labels
f: routesNavigator, Router, and related APIs.frameworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

Description

@xster
xster
opened on Sep 15, 2017

The material app has some nice routing functionalities like taking in a route->builder map, having an easy way to wrap a navigator with an initial page widget etc.

It'll be useful in different places like CupertinoTab and CupertinoApp.

Extract common logic (into a mixin perhaps).

Activity

  1. xster
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    f: routesNavigator, Router, and related APIs.
    on Sep 15, 2017
  2. xster
    self-assigned this
    on Sep 15, 2017

  3. xster commented on Feb 2, 2018

    @xster
    xster
    on Feb 2, 2018
    MemberAuthor

    Oh, we can probably just rename cupertino/tab_view.dart to widgets/routing_table.dart since that's pretty much all that CupertinoTabView does.

  4. xster
    assigned
    Hixie
    and unassigned
    xster
    on May 4, 2018

  5. xster commented on May 4, 2018

    @xster
    xster
    on May 4, 2018
    MemberAuthor

    Unassigning myself. Feel free to merge into other larger bugs as needed.

  6. Hixie
    assigned
    goderbauer
    and unassigned
    Hixie
    on Feb 28, 2019

  7. iapicca commented on Nov 1, 2019

    @iapicca
    iapicca
    on Nov 1, 2019

    Hi @goderbauer is this issue still meant to be open?

  8. iapicca
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Nov 1, 2019

  9. goderbauer commented on Nov 1, 2019

    @goderbauer
    goderbauer
    on Nov 1, 2019
    Member

    We are working on this, but it is not resolved yet.

  10. iapicca
    removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Nov 6, 2019
  11. goderbauer
    removed their assignment
    on Aug 4, 2020
  12. darshankawar
    added
    p: cupertino_uicupertino_ui package in flutter/packages
    passed first triage
    on Sep 4, 2020

  13. Hixie commented on Mar 2, 2023

    @Hixie
    Hixie
    on Mar 2, 2023
    Contributor

    I'm going to close this one on the basis that the new Router API provides a mechanism that's general and is already extracted. We might want to do this for the old API too one day, but if so, we should do it when we have a need for it.

  14. Hixie
    closed this as completedon Mar 2, 2023

  15. github-actions commented on Mar 16, 2023

    @github-actions
    github-actionsbot
    on Mar 16, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  16. github-actions
    locked as resolved and limited conversation to collaborators on Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    f: routesNavigator, Router, and related APIs.frameworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions