Repository navigation
TextField doesn't properly create a new TextEditingController on didUpdateWidget #12153
Description
In TextEditingController's didUpdateWidget method:
@override
void didUpdateWidget(TextField oldWidget) {
super.didUpdateWidget(oldWidget);
if (widget.controller == null && oldWidget.controller != null)
_controller == new TextEditingController.fromValue(oldWidget.controller.value);
else if (widget.controller != null && oldWidget.controller == null)
_controller = null;
}When widget.controller is null and oldWidget.controller isn't, _controller gets assigned instead of copied. Specifically, this:
_controller == new TextEditingController.fromValue(oldWidget.controller.value);should be
_controller = new TextEditingController.fromValue(oldWidget.controller.value);
Activity
Hixie commentedon Sep 18, 2017
(Filed dart-lang/sdk#30793 for a lint that would have caught this.)
cc @xster, @cbracken
cbracken commentedon Sep 20, 2017
Thanks! Fixed by #12190.
github-actions commentedon Sep 4, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.