Repository navigation
Mac web_tool_tests has become very flaky #123018
Description
Failures are in hot restart tests. In the past 6 flakes, there have been failures in two different unit tests. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20web_tool_tests/11270/overview and
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20web_tool_tests/11260/overview
The failures look similar though. From the first link:
[ +53 ms] DwdsVmClient: Successful hot restart
[ +2 ms] ChromeProxyService: Caching package:flutter/src/widgets/widget_inspector.dart in expression compiler worker
[ ] DevHandler: VmService proxy responded with an error:
{jsonrpc: 2.0, id: 15, error: {code: -32603, message: getIsolate: [Sentinel kind: Collected, valueAsString: Unrecognized isolateId: 1] from getIsolate(), data: {details: #0 ChromeProxyService._throwSentinel (package:dwds/src/services/chrome_proxy_service.dart:1154:5)
#1 ChromeProxyService._checkIsolate (package:dwds/src/services/chrome_proxy_service.dart:1146:7)
#2 ChromeProxyService.getIsolate.<anonymous closure> (package:dwds/src/services/chrome_proxy_service.dart:569:7)
<asynchronous suspension>
#3 StackZoneSpecification._registerUnaryCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:124:15)
<asynchronous suspension>
}}}
From the second link:
[ +49 ms] DwdsVmClient: Successful hot restart
[ +1 ms] ChromeProxyService: Caching package:flutter/src/widgets/widget_inspector.dart in expression compiler worker
[ ] DevHandler: VmService proxy responded with an error:
{jsonrpc: 2.0, id: 15, error: {code: -32603, message: getIsolate: [Sentinel kind: Collected, valueAsString: Unrecognized isolateId: 1] from getIsolate(), data: {details: #0 ChromeProxyService._throwSentinel (package:dwds/src/services/chrome_proxy_service.dart:1154:5)
#1 ChromeProxyService._checkIsolate (package:dwds/src/services/chrome_proxy_service.dart:1146:7)
#2 ChromeProxyService.getIsolate.<anonymous closure> (package:dwds/src/services/chrome_proxy_service.dart:569:7)
<asynchronous suspension>
#3 StackZoneSpecification._registerUnaryCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:124:15)
<asynchronous suspension>
}}}
Activity
zanderso commentedon Mar 20, 2023
@elliette for dwds.
zanderso commentedon Mar 20, 2023
I see @christopherfujino also recently touched this file in #122855
zanderso commentedon Mar 20, 2023
And @annagrin in #122776
Skip web hot restart tests
Skip web hot restart tests (#123019)
annagrin commentedon Mar 20, 2023
I fixed the flake in #122776 but it got reverted, I suspect due to new tests I've added that took the whole file over some threshold. @yjbanov @zanderso @christopherfujino the fixes are currently all in flutter tools. Would you like to take over this? Alternatively I could re-submit my fix and split the tests in two files. Hot restart tests are quite important so we don't want to keep them disabled for very long.
christopherfujino commentedon Mar 20, 2023
I'll attempt a re-land with more shards.
annagrin commentedon Mar 20, 2023
@christopherfujino FYI
@derekxu16 is currently working on a proper fix that will work for all vmService API so another option is to wait for the fix in the SDK to propagate (my patch should not be needed in that case): dart-lang/sdk#51752
derekxu16 commentedon Mar 20, 2023
Just published
package:vm_service v11.2.1. The problem should be fixed once that gets rolled into the Flutter SDK.https://pub.dev/packages/vm_service/versions/11.2.1
christopherfujino commentedon Mar 20, 2023
Nice, looks like rolling this is un-blocked, let me open a manual PR!
github-actions commentedon Apr 4, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.