[Camera] CameraController.takePicture() crashes due to Unconfigured Input/Output Surface #125314

Activity

1. MILLT189

   changed the title [-][Camera] CameraController.takePicture() crashes due to missing Input/Output Surface[/-] [+][Camera] CameraController.takePicture() crashes due to Unconfigured Input/Output Surface[/+] on Apr 21, 2023
2. camsim99 commented on Apr 21, 2023

   

   camsim99

   on Apr 21, 2023

   Last edited by camsim99

   Contributor

   More actions

   To reproduce this issue, I created a fresh Flutter app, copied the example app into my main.dart file, but changed my app to have a button to take a picture:

     @override
     Widget build(BuildContext context) {
       if (!controller.value.isInitialized) {
         return Container();
       }
       return MaterialApp(
         home: Scaffold(
           body: Column(children: <Widget>[
             CameraPreview(controller),
             IconButton(
                 onPressed: () async {
                   await controller.takePicture();
                 },
                 icon: const Icon(Icons.camera))
           ]),
         ),
       );
     }
   }

   I ran this on a Pixel 3 running Android 12 with camera version ^0.10.4, and it seems to work as expected.

   @MILLT189 are there any steps I'm missing in terms of reproducing the error you got? The similar issue you linked seems to also involve image streaming, so I'm wondering if you may be using that. Otherwise, I'm guessing this may be a device-specific or Android version specific issue.
3. MILLT189 commented on Apr 21, 2023

   

   MILLT189

   on Apr 21, 2023

   Author

   More actions

   @camsim99 my example app is using creating a CameraPreview (from Camera pub.dev) and starting a stream to use with MLKit barcode model.

   If you're not seeing issues with Android 12, I think it may be limited to devices running Android 13 (like my Galaxy S21 Ultra 5G)

   Source for camera preview init: https://pub.dev/packages/camera/example

   Widget cameraPreviewWidget = Expanded(
             child: Container(
                 decoration: cameraPreviewWidgetBoxDecoration,
                 height: deviceScreenHeight,
                 width: deviceScreenWidth,
                 child: CameraPreview(
                   cameraController!,
                   child: LayoutBuilder(
                     builder: (BuildContext context, BoxConstraints constraints) {
                       return GestureDetector(
                         behavior: HitTestBehavior.opaque,
                         onTapDown: (details) =>
                             onViewFinderTap(details, constraints),
                       );
                     },
                   ),
                 )));
   
4. MILLT189 commented on Apr 21, 2023

   

   MILLT189

   on Apr 21, 2023

   Author

   More actions

   As far as emulators are concerned, Pixel 4 with SDK 32 doesn't seem to throw any fatal errors when photo capture is attempted.

   When I run a Pixel 4 emulator with SDK 33, I'll get this error:

   E/MethodChannel#plugins.flutter.io/camera_android( 4145): Failed to handle method call
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): java.lang.NullPointerException: Attempt to invoke virtual method 'void android.hardware.camera2.CameraCaptureSession.stopRepeating()' on a null object reference
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at io.flutter.plugins.camera.Camera.pausePreview(Camera.java:1072)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at io.flutter.plugins.camera.MethodCallHandlerImpl.onMethodCall(MethodCallHandlerImpl.java:344)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:258)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:322)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at android.os.Handler.handleCallback(Handler.java:942)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at android.os.Handler.dispatchMessage(Handler.java:99)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at android.os.Looper.loopOnce(Looper.java:201)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at android.os.Looper.loop(Looper.java:288)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at android.app.ActivityThread.main(ActivityThread.java:7872)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at java.lang.reflect.Method.invoke(Native Method)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
   E/MethodChannel#plugins.flutter.io/camera_android( 4145): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
   I/Camera  ( 4145): runPrecaptureSequence
   I/Camera  ( 4145): refreshPreviewCaptureSession
   E/flutter ( 4145): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: CameraException(error, Attempt to invoke virtual method 'void android.hardware.camera2.CameraCaptureSession.stopRepeating()' on a null object reference)
   E/flutter ( 4145): #0      CameraController.pausePreview (package:camera/src/camera_controller.dart:378:7)
   E/flutter ( 4145): <asynchronous suspension>
   E/flutter ( 4145): 
   D/CameraCaptureCallback( 4145): CameraCaptureCallback | state: STATE_WAITING_PRECAPTURE_START | afState: 0 | aeState: 2
   D/CameraCaptureCallback( 4145): CameraCaptureCallback | state: STATE_WAITING_PRECAPTURE_DONE | afState: 0 | aeState: 5
   D/EGL_emulation( 4145): app_time_stats: avg=257.19ms min=7.01ms max=887.60ms count=4
   
   
5. camsim99 commented on Apr 21, 2023

   

   camsim99

   on Apr 21, 2023

   Last edited by camsim99

   Contributor

   More actions

   I modified my app to start image streaming before taking the photo, and I was able to reproduce this issue. So, it does seem related to #46082 (comment), as it seems to be caused by the combination of displaying a live preview, starting and image stream, and then taking a picture.
6. camsim99

   self-assigned this

   on Apr 21, 2023
7. camsim99

   added

   platform-androidAndroid applications specificallyAndroid applications specifically

   p: cameraThe camera pluginThe camera plugin

   on Apr 21, 2023
8. camsim99 commented on Apr 24, 2023

   

   camsim99

   on Apr 24, 2023

   Last edited by camsim99

   Contributor

   More actions

   At least part of the issue seems to be coming from the fact that the surface currently needed for image capture (retrieved from ImageReader#getSurface()) as seen here, is not part of the most recent call to create a CameraCaptureSession, as the most recent call is used to configure image streaming, as seen here. This is a requirement for CaptureRequest.Builder#addTarget(Surface) as per the docs.

   So, it seems like fixing this issue is a matter of properly configuring surfaces needed for image streaming and preview, as well as their respective ImageReaders.
9. camsim99

   added

   P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

   on Apr 27, 2023
10. tvolkert

    added

    customer: castaway

    on May 16, 2023
11. MILLT189 commented on Jun 12, 2023

    

    MILLT189

    on Jun 12, 2023

    Author

    More actions

    Is there an ETA for this??

    This crash is a blocker for my team and we need to be able to use the camera in order for us to use Flutter as a platform.
12. camsim99 commented on Jun 14, 2023

    

    camsim99

    on Jun 14, 2023

    Contributor

    More actions

    I'm picking back up work on this today, sorry for the delay. Will update here with status updates as soon as I can!
13. camsim99 commented on Jun 16, 2023

    

    camsim99

    on Jun 16, 2023

    Contributor

    More actions

    Status update: Seems like the comment I left above is the crux of the issue, but there is another issue concerning how we configure ImageReaders to pick up available images. At a high level, right now, we are configuring image capture essentially the same as image streaming, which is causing errors related to the listener used to receive the captured image. That listener is receiving multiple images because it is configured like image streaming and conflicting with the behavior of image streaming itself. Working on fixing this issue.
14. magraesser-disney commented on Jun 22, 2023

    

    magraesser-disney

    on Jun 22, 2023

    More actions

    Checking in for status on this issue.
15. AresVampire commented on Jun 22, 2023

    

    AresVampire

    on Jun 22, 2023

    More actions

    You must call stopImageStream first before taking photo with camera to avoid crash.
16. camsim99 commented on Jun 23, 2023

    

    camsim99

    on Jun 23, 2023

    Contributor

    More actions

    I have been out most of this week, apologies for the late update. I will return to hopefully finish solving the issue next week, but here is what I've found:

    Using multiple ImageReaders seems to be okay, but we will have to make sure we only save the image that matches the image that was captured. This involves adding images acquired/captured during a still capture to a queue that the still capture ImageReader can access and then use to match images it receives to the one captured image using image format and timestamp. It should look something closer to the camera2 example: https://github.com/android/camera-samples/blob/cce92313279754d08a77ee6c35ad8126e25e9245/Camera2Basic/app/src/main/java/com/example/android/camera2/basic/fragments/CameraFragment.kt#L322C9-L322C9.

    The tricky part is the fact that we don't know if the capture will finish first or the ImageReader will get access to a new image first. The camera2 example seems to assume an order (capture completes first), but this does not seem guaranteed by my own testing and a quick search. Will follow up on this to figure out the best way to proceed.
17. camsim99 commented on Jun 27, 2023

    

    camsim99

    on Jun 27, 2023

    Contributor

    More actions

    I was able to get still capture working with the queue/timestamp method, but like I mentioned above, it's harder when image streaming becomes involved because images will become available before the capture completes, so we end up acquiring > the max number of images we can at a time before closing them (as we add them to a queue and wait to check their timestamps). I am going to follow up today with folks more knowledgable on camera2 on whether or not there is a way to ensure the still capture ImageReader receives only one image as a result of the capture and if not, discuss strategies to best handle this timing issue.
18. camsim99 commented on Jun 27, 2023

    

    camsim99

    on Jun 27, 2023

    Contributor

    More actions

    It turns out that receiving multiple images was a result of using the surface of the JPEG ImageReader (the one for still capture) being set as a target of the request builder used for displaying a live preview, and using it to set a repeating request. Taking out that ImageReader's surface solves that issue. I already fixed the original issue by adding its surface to the capture session used for image streaming, so I will start on a PR for the fix.
19. auto-submit

    closed this as completedin packages#4332on Jun 30, 2023
20. auto-submit

    added a commit that references this issue on Jun 30, 2023

    [camera_android] Support concurrently image capture and image streami…

    ...

    d6e0d1f
21. github-actions commented on Jul 14, 2023

    

    github-actionsbot

    on Jul 14, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
22. github-actions

    locked as resolved and limited conversation to collaborators on Jul 14, 2023
23. creatorpiyush

    added a commit that references this issue on Jun 10, 2026

    [camera_android] Support concurrently image capture and image streami…

    ...

    f1561b1
24. bisor0627

    added a commit that references this issue on Jun 19, 2026

    [camera_android] Support concurrently image capture and image streami…

    ...

    fbb3dc7