Crash in DraggableScrollableController.animateTo #125709

Activity

1. Piinks

   added

   c: crashStack traces logged to the consoleStack traces logged to the console

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   a: animationAnimation APIsAnimation APIs

   f: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.

   P2

   customer: chalk (g3)

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Apr 28, 2023
2. Piinks commented on Apr 28, 2023

   

   Piinks

   on Apr 28, 2023

   ContributorAuthor

   More actions

   This is the code I have been trying to reproduce with, but this asserts against a shared controller before the sheets are swapped out. I have asked the customer to take a look and provide more information

   import 'package:flutter/material.dart';
   
   void main() {
     runApp(const MyApp());
   }
   
   class MyApp extends StatelessWidget {
     const MyApp({super.key});
   
     @override
     Widget build(BuildContext context) {
       return const MaterialApp(home: MyHomePage());
     }
   }
   
   class MyHomePage extends StatefulWidget {
     const MyHomePage({super.key});
   
     @override
     State<MyHomePage> createState() => _MyHomePageState();
   }
   
   class _MyHomePageState extends State<MyHomePage> {
     final _controller = DraggableScrollableController();
     bool useExpanded = false;
     final _maximizedInitialExtent = 1.00;
     final _minimizedSheetBaseHeight = 104.0;
     final _sheetAnimationDuration = const Duration(milliseconds: 200);
   
     @override
     Widget build(BuildContext context) {
       return Scaffold(
         appBar: AppBar(
           title: const Text('DraggableScrollableSheet'),
         ),
         body: NotificationListener<DraggableScrollableNotification>(
           onNotification: (scrollNotification) {
               if (scrollNotification.extent == scrollNotification.minExtent) {
                 print('Fully closed');
                 setState((){ useExpanded = false; });
               } else if (scrollNotification.extent == scrollNotification.maxExtent) {
                 print('Fully expanded');
                 setState((){ useExpanded = true; });
               }
               return true;
             },
           child: !useExpanded
           ? DraggableScrollableSheet(
             initialChildSize: 0.25,
             minChildSize: 0.25,
             controller: _controller,
             snap: true,
             snapSizes: const <double>[0.25, 1.0],
             builder: (BuildContext context, ScrollController scrollController) {
               return Container(
                 color: Colors.red[100],
                 child: ListView.builder(
                   controller: scrollController,
                   itemCount: 25,
                   itemBuilder: (BuildContext context, int index) {
                     if (index == 0) {
                       return TextButton(
                         child: const Text('Tap'),
                         onPressed: () => _controller.animateTo(
                           useExpanded
                               ? _calculateTrueMinimizedExtent(context: context)
                               : _maximizedInitialExtent,
                           duration: _sheetAnimationDuration,
                           curve: Curves.bounceInOut,
                         ),
                       );
                     }
                     return ListTile(title: Text('Item $index'));
                   },
                 ),
               );
             },
           )
           : Stack(
             children: [
               DraggableScrollableSheet(
                 initialChildSize: 1,
                 minChildSize: 0.25,
                 controller: _controller,
                 snap: true,
                 snapSizes: const <double>[0.25, 1.0],
                 builder: (BuildContext context, ScrollController scrollController) {
                   return Container(
                     color: Colors.blue[100],
                     child: ListView.builder(
                       controller: scrollController,
                       itemCount: 25,
                       itemBuilder: (BuildContext context, int index) {
                         if (index == 0) {
                       return TextButton(
                         child: const Text('Tap'),
                         onPressed: () => _controller.animateTo(
                           useExpanded
                               ? _calculateTrueMinimizedExtent(context: context)
                               : _maximizedInitialExtent,
                           duration: _sheetAnimationDuration,
                           curve: Curves.bounceInOut,
                         ),
                       );
                     }
                         return SizedBox(height: 50, child: Text('Item $index'));
                       },
                     ),
                   );
                 },
               ),
             ],
           ),
         ),
       );
     }
   
     double _calculateTrueMinimizedExtent({required BuildContext context}) {
       final screenHeight = MediaQuery.of(context).size.height;
       final sheetHeightPercentage = _minimizedSheetBaseHeight / screenHeight;
       return sheetHeightPercentage;
     }
   }
   
3. github-actions

   removed

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Apr 28, 2023
4. Piinks

   added

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Apr 28, 2023
5. dnfield commented on Apr 28, 2023

   

   dnfield

   on Apr 28, 2023

   Contributor

   More actions

   I have a test case in the linked PR, but I can make this happen by causing didUpdateWidget to happen during an animateTo.
6. dnfield commented on Apr 28, 2023

   

   dnfield

   on Apr 28, 2023

   Contributor

   More actions

   We didn't get coverage of that because the existing test that exercised didUpdateWidget called jumpTo.
7. dnfield

   self-assigned this

   on Apr 29, 2023
8. dnfield

   removed

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Apr 29, 2023
9. auto-submit

   closed this as completedin #125721on Apr 29, 2023
10. auto-submit

    added a commit that references this issue on Apr 29, 2023

    Fix crasher in DragableScrollableSheet when controller is animating a…

    ...

    e1e8ad8
11. github-actions commented on May 13, 2023

    

    github-actionsbot

    on May 13, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
12. github-actions

    locked as resolved and limited conversation to collaborators on May 13, 2023
13. flutter-triage-bot

    added

    P0Critical issues such as a build break or regressionCritical issues such as a build break or regression

    and removed

    P2

    on Jun 28, 2023