Skip to content

[camerax] ☂️ Clean up wrapped native classes #125926

Closed
Closed
[camerax] ☂️ Clean up wrapped native classes#125926
Labels
P3Issues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityc: tech-debtTechnical debt, code quality, testing, etc.p: cameraThe camera pluginpackageflutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

Description

@camsim99
camsim99
opened on May 2, 2023

As the android_camera_camerax plugin has been under development, there have a number of tasks that have not blocked PRs but are important technical debt to pay down. This umbrella issue covers those tasks that apply to refactoring wrapped native classes:

  • Refactor logic in constructors/create methods to helper methods or to callers of those methods.
  • Remove any redundant documentation added or left by the autogenerator.
  • [Dart-specific] Make Dart Host API implementations private.
  • There are currently two ways to create files to save recordings to; condense to one.
  • [Native-specific] Move checks for objects being managed by an InstanceManager to the Flutter API implementations themselves versus where instances of those implementations are used.
  • Use command pattern to use handlers to create objects of each type that is represented by a LiveDataSupportedType (see original comment).

Activity

  1. camsim99
    added
    c: new featureNothing broken; request for a new capability
    platform-androidAndroid applications specifically
    p: cameraThe camera plugin
    packageflutter/packages repository. See also p: labels.
    P3Issues that are less important to the Flutter project
    c: tech-debtTechnical debt, code quality, testing, etc.
    on May 2, 2023
  2. auto-submit
    added a commit that references this issue on May 9, 2023

    [camerax] Implement onCameraClosing (#3878)

    c62f6f7
  3. flutter-triage-bot
    added
    multiteam-retriage-candidate
    team-androidOwned by Android platform team
    triaged-androidTriaged by Android platform team
    on Jul 8, 2023
  4. nploi
    added a commit that references this issue on Jul 16, 2023

    [camerax] Implement onCameraClosing (flutter#3878)

    6b71596
  5. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024

  6. camsim99 commented on Jul 7, 2025

    @camsim99
    camsim99
    on Jul 7, 2025
    ContributorAuthor

    We no longer have wrapper classes with proxy apis now used!

  7. camsim99
    closed this as completedon Jul 7, 2025

  8. github-actions commented on Jul 21, 2025

    @github-actions
    github-actionsbot
    on Jul 21, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityc: tech-debtTechnical debt, code quality, testing, etc.p: cameraThe camera pluginpackageflutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions