Repository navigation
[flutter_markdown]: Unable to use MarkdownElementBuilder to act on img tag #126402
Copy link
Copy link
Closed
flutter/packages
#3952Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listfound in release: 3.11Found to occur in 3.11Found to occur in 3.11found in release: 3.7Found to occur in 3.7Found to occur in 3.7has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onp: flutter_markdownflutter/packages flutter_markdownflutter/packages flutter_markdownpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version
Description
Is there an existing issue for this?
- I have searched the existing issues
- I have read the guide to filing a bug
Steps to reproduce
run sample code:
import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
import 'package:markdown/markdown.dart' as md;
const String _data = '''
## sample Text

###### ※ ※ ※
''';
void main() {
runApp(
MaterialApp(
title: 'Markdown Demos',
home: TestPage(),
),
);
}
class TestPage extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text("ImgBuilderDemo"),
),
body: Center(
child: ImgBuilderDemo(),
),
);
}
}
class ImgBuilderDemo extends StatelessWidget {
const ImgBuilderDemo({super.key});
Future<String> get data => Future<String>.value(_data);
@override
Widget build(BuildContext context) {
return FutureBuilder<String>(
future: data,
builder: (BuildContext context, AsyncSnapshot<String> snapshot) {
if (snapshot.connectionState == ConnectionState.done) {
return Markdown(
data: snapshot.data!,
builders: <String, MarkdownElementBuilder>{
'img': ImgBuilder(),
},
);
} else {
return const CircularProgressIndicator();
}
},
);
}
}
class ImgBuilder extends MarkdownElementBuilder {
@override
Widget? visitElementAfter(md.Element element, TextStyle? preferredStyle) {
return Text("test", style: preferredStyle);
}
}Expected results
Replace all img in raw data with widget built in ImgBuilder:
class ImgBuilder extends MarkdownElementBuilder {
@override
Widget? visitElementAfter(md.Element element, TextStyle? preferredStyle) {
return Text("test", style: preferredStyle);
}
}Actual results
get error:
======== Exception caught by widgets library =======================================================
The following RangeError was thrown building FutureBuilder<String>(state: _FutureBuilderState<String>#5f8b8):
RangeError (index): Invalid value: Valid value range is empty: 0
The relevant error-causing widget was:
FutureBuilder<String> FutureBuilder:file:///Users/yangjiakang/Code/packages/packages/flutter_markdown/example/lib/main.dart:104:12
When the exception was thrown, this was the stack:
#0 List._setIndexed (dart:core-patch/growable_array.dart:273:49)
#1 List.[]= (dart:core-patch/growable_array.dart:268:5)
#2 MarkdownBuilder.visitElementAfter (package:flutter_markdown/src/builder.dart:468:27)
#3 Element.accept (package:markdown/src/ast.dart:53:15)
#4 Element.accept (package:markdown/src/ast.dart:50:17)
#5 MarkdownBuilder.build (package:flutter_markdown/src/builder.dart:187:12)
#6 _MarkdownWidgetState._parseMarkdown (package:flutter_markdown/src/widget.dart:341:25)
#7 _MarkdownWidgetState.didChangeDependencies (package:flutter_markdown/src/widget.dart:285:5)
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';
import 'package:markdown/markdown.dart' as md;
const String _data = '''
## sample Text

###### ※ ※ ※
''';
void main() {
runApp(
MaterialApp(
title: 'Markdown Demos',
home: TestPage(),
),
);
}
class TestPage extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text("ImgBuilderDemo"),
),
body: Center(
child: ImgBuilderDemo(),
),
);
}
}
class ImgBuilderDemo extends StatelessWidget {
const ImgBuilderDemo({super.key});
Future<String> get data => Future<String>.value(_data);
@override
Widget build(BuildContext context) {
return FutureBuilder<String>(
future: data,
builder: (BuildContext context, AsyncSnapshot<String> snapshot) {
if (snapshot.connectionState == ConnectionState.done) {
return Markdown(
data: snapshot.data!,
builders: <String, MarkdownElementBuilder>{
'img': ImgBuilder(),
},
);
} else {
return const CircularProgressIndicator();
}
},
);
}
}
class ImgBuilder extends MarkdownElementBuilder {
@override
Widget? visitElementAfter(md.Element element, TextStyle? preferredStyle) {
return Text("test", style: preferredStyle);
}
}Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
======== Exception caught by widgets library =======================================================
The following RangeError was thrown building FutureBuilder<String>(state: _FutureBuilderState<String>#5f8b8):
RangeError (index): Invalid value: Valid value range is empty: 0
The relevant error-causing widget was:
FutureBuilder<String> FutureBuilder:file:///Users/yangjiakang/Code/packages/packages/flutter_markdown/example/lib/main.dart:104:12
When the exception was thrown, this was the stack:
#0 List._setIndexed (dart:core-patch/growable_array.dart:273:49)
#1 List.[]= (dart:core-patch/growable_array.dart:268:5)
#2 MarkdownBuilder.visitElementAfter (package:flutter_markdown/src/builder.dart:468:27)
#3 Element.accept (package:markdown/src/ast.dart:53:15)
#4 Element.accept (package:markdown/src/ast.dart:50:17)
#5 MarkdownBuilder.build (package:flutter_markdown/src/builder.dart:187:12)
#6 _MarkdownWidgetState._parseMarkdown (package:flutter_markdown/src/widget.dart:341:25)
#7 _MarkdownWidgetState.didChangeDependencies (package:flutter_markdown/src/widget.dart:285:5)Flutter Doctor output
Doctor output
[!] Flutter (Channel unknown, 3.11.0-2.0.pre.51, on macOS 13.0.1 22A400
darwin-arm64, locale zh-Hans-CN)
! Flutter version 3.11.0-2.0.pre.51 on channel unknown at
/Users/yangjiakang/flutter/framework
Currently on an unknown channel. Run `flutter channel` to switch to an
official channel.
If that doesn't fix the issue, reinstall Flutter by following instructions
at https://flutter.dev/docs/get-started/install.
! Unknown upstream repository.
Reinstall Flutter by following instructions at
https://flutter.dev/docs/get-started/install.
• Framework revision 7c356d047d (4 天前), 2023-05-06 12:22:11 +0800
• Engine revision 876968833e
• Dart version 3.1.0 (build 3.1.0-82.0.dev)
• DevTools version 2.23.1
• If those were intentional, you can disregard the above warnings; however
it is recommended to use "git" directly to perform update checks and
upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
• Android SDK at /Users/yangjiakang/Library/Android/sdk
• Platform android-33, build-tools 33.0.1
• ANDROID_HOME = /Users/yangjiakang/Library/Android/sdk
• ANDROID_SDK_ROOT = /Users/yangjiakang/Library/Android/sdk
• Java binary at: /Applications/Android
Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
11.0.15+0-b2043.56-8887301)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14A400
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio
• Android Studio at /Applications/Android Studio Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.4.1+0-17.0.4.1b469.62-9127311)
[✓] Android Studio (version 2022.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
11.0.15+0-b2043.56-8887301)
[✓] Android Studio
• Android Studio at
/Users/yangjiakang/Code/androidx/studio/android-studio-2022.2.1.7-mac_arm/
Android Studio Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.4.1+0-17.0.4.1b469.62-9127311)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.3.2)
• IntelliJ at /Applications/IntelliJ IDEA.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.78.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[!] Proxy Configuration
• HTTP_PROXY is set
• NO_PROXY is localhost,127.0.0.1
• NO_PROXY contains localhost
• NO_PROXY contains 127.0.0.1
! NO_PROXY does not contain ::1
[✓] Connected device (3 available)
• PERM00 (mobile) • XOCAQ87LIR597TEA • android-arm64 • Android 12 (API 31)
• macOS (desktop) • macos • darwin-arm64 • macOS 13.0.1 22A400
darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome
113.0.5672.92
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 2 categories.Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listfound in release: 3.11Found to occur in 3.11Found to occur in 3.11found in release: 3.7Found to occur in 3.7Found to occur in 3.7has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onp: flutter_markdownflutter/packages flutter_markdownflutter/packages flutter_markdownpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version
Activity
huycozy commentedon May 10, 2023
Thanks for the report and PR. Reproduced this issue on the latest version
flutter_markdown: ^0.6.14. The stack trace is not really the same but it seems to mention the same cause (also based on your PR fix).Logs
flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.0.1 22A400 darwin-x64, locale en-VN) • Flutter version 3.7.12 on channel stable at /Users/huynq/Documents/GitHub/flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision 4d9e56e694 (2 days ago), 2023-04-17 21:47:46 -0400 • Engine revision 1a65d409c7 • Dart version 2.19.6 • DevTools version 2.20.1 [✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0) • Android SDK at /Users/huynq/Library/Android/sdk • Platform android-33, build-tools 32.0.0 • ANDROID_HOME = /Users/huynq/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 14.3) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 14E222b • CocoaPods version 1.11.3 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2022.1) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301) [✓] IntelliJ IDEA Community Edition (version 2022.1.1) • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart [✓] VS Code (version 1.77.3) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.62.0 [✓] Connected device (3 available) • SM T225 (mobile) • R9JT3004VRJ • android-arm64 • Android 13 (API 33) • macOS (desktop) • macos • darwin-x64 • macOS 13.0.1 22A400 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 112.0.5615.137 [✓] HTTP Host Availability • All required HTTP hosts are available • No issues found!MuhammedKpln commentedon May 27, 2023
Getting same error as well when trying to replace checkbox with custom checkbox.
MeandNi commentedon May 29, 2023
flutter/packages#3952 @stuartmorgan Is there any problem with this PR?
[flutter_markdown] Unable to use MarkdownElementBuilder to act those …
github-actions commentedon Jun 14, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[flutter_markdown] Unable to use MarkdownElementBuilder to act those …
[flutter_markdown] Unable to use MarkdownElementBuilder to act those …