Skip to content

Get framework tests running with dart2wasm #126692

Closed

Description

@eyebrowsoffire

Right now we have the following test coverage for the experimental dart2wasm feature:

  • Engine unit tests compile to dart2wasm and run on CI, which extensively exercise the web engine, but does so before the sdk_rewriter transformations
  • End-to-end integration tests in the framework that ensure that we can build a flutter app with flutter build web --wasm with different parameters. This doesn't actually execute anything in the app, however

We need to add support for running the framework tests themselves with a dart2wasm compiled app.

One caveat is that, for complicated build reasons, when the dart monorepo runs the framework tests, it won't have wasm-opt in the dart-sdk bundle it is using. So we probably need to just turn wasm-opt off in whatever code paths the dart monorepo may end up using.

Activity

  1. added
    P1High-priority issues at the top of the work list
    on Jun 22, 2023
  2. github-actions commented on Apr 4, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P1High-priority issues at the top of the work liste: wasmIssues related to the wasm build of Flutter Web.platform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions