Repository navigation
[flutter_adaptive_scaffold] : Bottom Navigation bar height is too much in Flutter 3.10.1 #127088
Copy link
Copy link
Closed
flutter/packages
#4661Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowfound in release: 3.10Found to occur in 3.10Found to occur in 3.10found in release: 3.11Found to occur in 3.11Found to occur in 3.11has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onp: flutter_adaptive_scaffoldThe flutter_adaptive_scaffold packageThe flutter_adaptive_scaffold packagep: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packagespackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team
Description
Is there an existing issue for this?
- I have searched the existing issues
- I have read the guide to filing a bug
Steps to reproduce
- Run adaptive scaffold demo example in iPhone or Android platform.
- Check the height of bottom navigation bar.
- It is way bigger than it should be.
Expected results
- Height should be constraints to the height given or default height.
- Height is not proper as of now and takes a very large amount of screen with it. (screenshot below)
Actual results
- Bottom navigation bar's height shall be proper as it was before.
Code sample
Code sample
NO code changes made.Screenshots or Video
Logs
Logs
No crash logs, but able to reproduce with Flutter version 3.10.1Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.1, on macOS 13.1 22C65 darwin-arm64, locale en-IN)
• Flutter version 3.10.1 on channel stable at /Users/aliasgarvohra/Development/FlutterSDK/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision d3d8effc68 (29 hours ago), 2023-05-16 17:59:05 -0700
• Engine revision b4fb11214d
• Dart version 3.0.1
• DevTools version 2.23.1
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
• Android SDK at /Users/aliasgarvohra/Library/Android/sdk
• Platform android-33, build-tools 33.0.1
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E222b
• CocoaPods version 1.12.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
[✓] VS Code (version 1.78.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.64.0
[✓] Connected device (3 available)
• iPhone 14 Pro Max (mobile) • FEE2A9D1-191A-4907-B550-894D99F1E0E7 • ios • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
• macOS (desktop) • macos • darwin-arm64 • macOS 13.1 22C65 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 113.0.5672.126
[✓] Network resources
• All expected network resources are available.
• No issues found!Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: regressionIt was better in the past than it is nowIt was better in the past than it is nowfound in release: 3.10Found to occur in 3.10Found to occur in 3.10found in release: 3.11Found to occur in 3.11Found to occur in 3.11has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onp: flutter_adaptive_scaffoldThe flutter_adaptive_scaffold packageThe flutter_adaptive_scaffold packagep: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packagespackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team

Activity
huycozy commentedon May 18, 2023
Thank you for the report. This issue seems to be introduced on
flutter_adaptive_scaffold: ^0.1.4version, see changelog.And this issue doesn't occur in the previous version
0.1.3as it usedBottomNavigationBar. Related issue: #124984.Labeling the issue for further investigation.
flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.10.1, on macOS 13.0.1 22A400 darwin-x64, locale en-VN) • Flutter version 3.10.1 on channel stable at /Users/huynq/Documents/GitHub/flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision d3d8effc68 (26 hours ago), 2023-05-16 17:59:05 -0700 • Engine revision b4fb11214d • Dart version 3.0.1 • DevTools version 2.23.1 [✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0) • Android SDK at /Users/huynq/Library/Android/sdk • Platform android-33, build-tools 32.0.0 • ANDROID_HOME = /Users/huynq/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 14.3) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 14E222b • CocoaPods version 1.11.3 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2022.2) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694) [✓] VS Code (version 1.78.1) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.64.0 [✓] Connected device (3 available) • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64 • Android 11 (API 30) • macOS (desktop) • macos • darwin-x64 • macOS 13.0.1 22A400 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 113.0.5672.126 [✓] Network resources • All expected network resources are available. • No issues found!fmt-Println-MKO commentedon May 19, 2023
it only happens on iOS and Android, Web is fine.
there is a padding added, somewhere from SlotLayout. I think it have something todo with the animation.
aliasgar4558 commentedon May 19, 2023
@fmt-Println-MKO : Seems like in SlotLayout, there is no change since 2022-August. So need to check the root cause of this issue. Also as you said, it is working fine in web, I checked that as well.
fmt-Println-MKO commentedon May 19, 2023
@aliasgar4558 Yes, I just checked the NavigationBar without SlotLayout and there it's fine, no padding.
I think the padding is somewhere calculated as the space for the animation that is used.
If you browse the widget tree you see the padding inside the Ink Widget
As it's fine for the web, there needs to be a calculation with Android iOS check before.
heralight commentedon Jun 2, 2023
hi,
is it perhaps related to #119526 and #123746 ?
I have the same problem after migrating from 3.7 to 3.10 with the simple Scaffold.bottomNavigationBar.
aliasgar4558 commentedon Jun 3, 2023
@heralight, I faced this one in latest package version. Flutter sdk version won't matter, like if you are on 3.7 and try same thing with latest package version, then also it will be reproduced.
16 remaining items
darkalfx commentedon Jul 12, 2023
Not a problem on Windows, but a pretty big one on ios.
The worst part about it how difficult a workaround is to fix it.
Im gonna have to use a stack instead of relying on the scaffold and why?
Just let us specify the padding.
aliasgar4558 commentedon Jul 31, 2023
Any fix on the same ??
JonasESmith commentedon Jul 31, 2023
For the time being I am just using something like bellow so that it functions at all.
hgaron-blockbar commentedon Aug 21, 2023
I also have this issue - I didn't notice as I've been building for mac and didn't have the issue. Then I previewed in iOS and noticed it right away.
[flutter_adaptive_scaffold] Fix top padding for NavigationBar (#4661)
github-actions commentedon Sep 5, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutte…
[flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutte…