Skip to content

Create utility function to pass ProcessResult along with anticipated exit code + implement within flakes #127135

Closed

Description

@eliasyishak

This utility function will be used in integration tests to check the result of a process to ensure the exit code expected is returned, if the exit code returned is not what was expected, the function will print out the stdout, stderr, and exit_code

Activity

  1. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    on May 18, 2023
  2. self-assigned this
    on May 18, 2023
  3. eliasyishak commented on May 18, 2023

    @eliasyishak
    ContributorAuthor
  4. christopherfujino commented on May 19, 2023

    @christopherfujino
    Contributor

    Ooh, if you want to be fancy this can be a matcher. Here's some prior art: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/src/common.dart#LL91C62-L91C62

  5. changed the title [-]Create utility function to pass `ProcessResult` along with anticipated exit code[/-] [+]Create utility function to pass `ProcessResult` along with anticipated exit code + implement within flakes[/+] on May 30, 2023
  6. eliasyishak commented on May 30, 2023

    @eliasyishak
    ContributorAuthor

    After #127414 landed, implementing in flakes identified below

  7. github-actions commented on Jun 16, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

toolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions