Skip to content

Flutter iOS builds should verify that Generated.xcconfig is included in the configuration #12749

Open
Open
Flutter iOS builds should verify that Generated.xcconfig is included in the configuration#12749
Labels
P3Issues that are less important to the Flutter projectplatform-iosiOS applications specificallyt: xcode"xcodebuild" on iOS and general Xcode project managementteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform team

Description

@cbracken
cbracken
opened on Oct 27, 2017

The FLUTTER_* variables defined in Generated.xcconfig are critical to successfully building for iOS. These are used in at least two key places:

  1. To locate the the xcode_backend.sh file in the build run-script phase.
  2. Within of xcode_backend.sh, for the various Flutter build settings.

We should detect that this file is (transitively) included from the build configuration's .xcconfig. One way to do this might just be to use xcodebuild -showBuildSettings and verify that all required variables are set. That avoids parsing Xcode project files and tying ourselves to a proprietary file format that could change.

Activity

  1. cbracken
    added
    toolAffects the "flutter" command-line tool. See also t: labels.
    platform-iosiOS applications specifically
    on Oct 27, 2017
  2. zoechi
    added
    waiting for PR to land (fixed)A fix is in flight
    on Dec 31, 2018
  3. jonahwilliams
    removed
    waiting for PR to land (fixed)A fix is in flight
    on Apr 24, 2019

  4. iapicca commented on Nov 1, 2019

    @iapicca
    iapicca
    on Nov 1, 2019

    Hi @cbracken is this issue still meant to be open?

  5. iapicca
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    and removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Nov 1, 2019
  6. jmagman
    added
    t: xcode"xcodebuild" on iOS and general Xcode project management
    on Jan 9, 2020
  7. jmagman
    added
    P3Issues that are less important to the Flutter project
    on Aug 18, 2020
  8. flutter-triage-bot
    added
    multiteam-retriage-candidate
    team-iosOwned by iOS platform team
    triaged-iosTriaged by iOS platform team
    on Jul 8, 2023
  9. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectplatform-iosiOS applications specificallyt: xcode"xcodebuild" on iOS and general Xcode project managementteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions