Skip to content

Xcode Archive builds should automatically build in release mode #12774

Closed
Closed
Xcode Archive builds should automatically build in release mode#12774
Labels
customer: crowdAffects or could affect many people, though not necessarily a specific customer.p: toolingAffects the flutter_plugin_tools packagetoolAffects the "flutter" command-line tool. See also t: labels.

Description

@cbracken
cbracken
opened on Oct 28, 2017

As of #12773, running Archive from Xcode will exit immediately with a useful error message if flutter build ios --release hasn't been executed. When building Archive releases from Xcode, we should automatically build in release mode.

This requires at least the following:

  1. Update Generated.xcconfig to a release mode build.
  2. Run pod install to update the Podfile.lock to use the release-mode framework

Ideally, Xcode builds wouldn't rely on Generated.xcconfig for build-mode related settings, but would determine build mode from Xcode's own Debug vs Release configuration.

Activity

  1. cbracken
    added
    cla: no
    toolAffects the "flutter" command-line tool. See also t: labels.
    p: toolingAffects the flutter_plugin_tools package
    and removed
    cla: no
    on Oct 28, 2017

  2. zoechi commented on Dec 11, 2018

    @zoechi
    zoechi
    on Dec 11, 2018
    Contributor

    Might be related to #24641

  3. iapicca commented on Nov 1, 2019

    @iapicca
    iapicca
    on Nov 1, 2019

    Hi @cbracken is this issue still meant to be open?

  4. iapicca
    added
    customer: crowdAffects or could affect many people, though not necessarily a specific customer.
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    and removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Nov 1, 2019

  5. jmagman commented on Jan 18, 2020

    @jmagman
    jmagman
    on Jan 18, 2020
    Member

    I think this was fixed with a combination of #23387 and #42029. The build configuration from Xcode is used to decide what build_mode to use, and that version of the engine is re-copied in, regardless of whether you ran flutter build ios --release on the command line.

    However I think it's nice to keep that message in xcode_backend in case we ever regress this logic.

    Can we close this, @cbracken?

  6. jmagman
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Jan 18, 2020

  7. cbracken commented on Jan 18, 2020

    @cbracken
    cbracken
    on Jan 18, 2020
    MemberAuthor

    Sounds closeable (and agreed on keeping the message in just in case).

  8. cbracken
    closed this as completedon Jan 18, 2020
  9. no-response
    removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Jan 18, 2020

  10. github-actions commented on Aug 23, 2021

    @github-actions
    github-actionsbot
    on Aug 23, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. github-actions
    locked as resolved and limited conversation to collaborators on Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    customer: crowdAffects or could affect many people, though not necessarily a specific customer.p: toolingAffects the flutter_plugin_tools packagetoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions