Skip to content

[1P Packages] Update code samples of packages that use video_player in their examples.  #127754

Closed
flutter/packages
#5653
Closed
[1P Packages] Update code samples of packages that use video_player in their examples. #127754
flutter/packages
#5653
Assignees
stuartmorgan-g
Labels
P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.d: examplesSample code and demosp: cameraThe camera pluginp: image_pickerThe Image Picker plugin.packageflutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionteam-ecosystemOwned by Ecosystem team

Description

@gabrielokura
gabrielokura
opened on May 27, 2023

Since flutter/packages#3513 is adding a new URI-typed factory method, the following packages needs to update it's deprecated examples:

  • camera/camera
  • camera/camera_android
  • camera/camera_android_camerax
  • camera/camera_avfoundation
  • image_picker/image_picker
  • image_picker/image_picker_android
  • image_picker/image_picker_ios

The fix should be similar to this code

// deprecated
final VideoPlayerController vController = kIsWeb
        ? VideoPlayerController.network(videoFile!.path)
        : VideoPlayerController.file(File(videoFile!.path));
        
// fixed
final VideoPlayerController vController = kIsWeb
        ? VideoPlayerController.networkUrl(Uri.parse(videoFile!.path))
        : VideoPlayerController.file(File(videoFile!.path));

Also, this update will fix the analyze's tests:

[31mThe following packages had errors:�[0m
[31m  camera/camera�[0m
[31m  camera_android�[0m
[31m  camera_android_camerax�[0m
[31m  camera_avfoundation�[0m
[31m  image_picker/image_picker�[0m
[31m  image_picker_android�[0m
[31m  image_picker_ios�[0m
[31mSee above for full details.�[0m

Activity

  1. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    on May 29, 2023
  2. danagbemava-nc
    changed the title [-][video_player] Update deprecated examples [/-] [+][1P Packages] Update code samples of packages that use video_player in their examples. [/+] on May 29, 2023
  3. danagbemava-nc
    added
    d: examplesSample code and demos
    p: cameraThe camera plugin
    p: image_pickerThe Image Picker plugin.
    packageflutter/packages repository. See also p: labels.
    documentation
    and removed
    in triagePresently being triaged by the triage team
    on May 29, 2023
  4. stuartmorgan-g
    added
    P2Important issues not at the top of the work list
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Jun 13, 2023

  5. stuartmorgan-g commented on Jun 13, 2023

    @stuartmorgan-g
    stuartmorgan-g
    on Jun 13, 2023
    Contributor

    Triaging under the expectation of the linked PR landing; it's not valid until that PR does land however.

  6. stuartmorgan-g
    added
    P1High-priority issues at the top of the work list
    and removed
    P2Important issues not at the top of the work list
    on Jun 22, 2023
  7. Hixie
    removed
    documentation
    on Jul 5, 2023
  8. flutter-triage-bot
    added
    team-ecosystemOwned by Ecosystem team
    triaged-ecosystemTriaged by Ecosystem team
    on Jul 8, 2023
  9. flutter-triage-bot
    removed
    triaged-ecosystemTriaged by Ecosystem team
    on Dec 11, 2023

  10. flutter-triage-bot commented on Dec 11, 2023

    @flutter-triage-bot
    flutter-triage-botbot
    on Dec 11, 2023

    This issue is marked P1 but has had no recent status updates.

    The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

    Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

  11. stuartmorgan-g
    self-assigned this
    on Dec 12, 2023
  12. auto-submit
    closed this as completedin packages#5653on Dec 12, 2023
  13. auto-submit
    added a commit that references this issue on Dec 12, 2023

    [various] Update examples using video_player (#5653)

    bf6c32c
  14. danagbemava-nc
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Dec 13, 2023

  15. github-actions commented on Dec 27, 2023

    @github-actions
    github-actionsbot
    on Dec 27, 2023 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  16. github-actions
    locked as resolved and limited conversation to collaborators on Dec 27, 2023
  17. creatorpiyush
    added a commit that references this issue on Jun 10, 2026

    [various] Update examples using video_player (flutter#5653)

    bfa0683
  18. bisor0627
    added a commit that references this issue on Jun 19, 2026

    [various] Update examples using video_player (flutter#5653)

    dadd0aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.d: examplesSample code and demosp: cameraThe camera pluginp: image_pickerThe Image Picker plugin.packageflutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionteam-ecosystemOwned by Ecosystem team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions