flutter analyze --flutter-repo should analyze analysis_options.yaml #127989

Activity

1. goderbauer

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on May 31, 2023
2. goderbauer commented on May 31, 2023

   

   goderbauer

   on May 31, 2023

   MemberAuthor

   More actions

   While looking at this I noticed that the Flutter tool actually jumps through some extra hoops to only analyze the dev, examples, and packages directory:

   flutter/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart

   Lines 312 to 318 in 19719e3

   	List<String> getRepoRoots() {
   	final String root = globals.fs.path.absolute(Cache.flutterRoot!);
   	// not bin, and not the root
   	return <String>['dev', 'examples', 'packages'].map<String>((String item) {
   	return globals.fs.path.join(root, item);
   	}).toList();
   	}

   I wonder why we decided to do that? It seems like it would be easier to just run the analyze command on the root of the repository and use the excludes section in the analysis_options.yaml file to exclude the only directory we don't want to analyze: bin. (We already use the excludes section to exclude other parts of the repo from analysis.) This would also ensure that the analysis_options.yaml file itself at the root of the repo is analyzed.

   In theory, with this approach we could even deprecated the --flutter-repo special flag and just run flutter analyze . in the root of the repository everywhere (e.g. on CI)...
3. goderbauer commented on May 31, 2023

   

   goderbauer

   on May 31, 2023

   MemberAuthor

   More actions

   cc @christopherfujino

   cc @Hixie This should explains why the deprecation notices you saw locally are not breaking our CI. It doesn't explain why you saw those notices locally in the first place, though...
4. auto-submit

   closed this as completedin #127990on Jun 2, 2023
5. auto-submit

   added a commit that references this issue on Jun 2, 2023

   Make --flutter-repo analyze whole repo (#127990)

   ...

   95cd3c0
6. whesse commented on Jun 7, 2023

   

   whesse

   on Jun 7, 2023

   Contributor

   More actions

   The fix landed for this issue runs the analyzer on all subdirectories of the flutter checkout, and that can include user-created directories that don't contain flutter source at all.

   For example, to make a hermetic image for flutter, Golem puts the pub cache in a pub-cache directory, and sets the analysis server temp directory to .dartServer, both in the root directory of flutter. I see notes where other users put config directories here rather than in their home directory. Only files that are part of the flutter repo should be analyzed by this command.
7. github-actions commented on Jun 21, 2023

   

   github-actionsbot

   on Jun 21, 2023

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
8. github-actions

   locked as resolved and limited conversation to collaborators on Jun 21, 2023