Skip to content

[CP] Do not try to load main/default asset image if only higher-res variants exist #128450

Closed
Closed
[CP] Do not try to load main/default asset image if only higher-res variants exist#128450
Assignees
CaseyHillers
Labels
cp: approvedApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Description

@andrewkolos
andrewkolos
opened on Jun 7, 2023

Issue Link

#127090

Commit Hash

759ebef

Target

stable

PR Link

#128449

Changelog Description

Restores the ability to define an asset that only has resolution-aware variants.

Impacted Users

all Flutter devs

Impact Description

Impacts the shipping production app. Customer apps on running on devices with low pixel densities may not be able to display assets.

Workaround

Yes. The user can still declare the resolution-aware variants explicitly in pubspec.yaml. They can also add the parent directory as an entry in pubspec.yaml.

Risk

low

Test Coverage

yes

Validation Steps

The original issue has a repro that can be tested with a low DPR device (like an iPhone 3 SE)

Activity

  1. andrewkolos
    added
    cp: reviewCherry-picks in the review queue
    on Jun 7, 2023

  2. andrewkolos commented on Jun 7, 2023

    @andrewkolos
    andrewkolos
    on Jun 7, 2023
    ContributorAuthor

    cc @jonahwilliams

  3. jonahwilliams commented on Jun 7, 2023

    @jonahwilliams
    jonahwilliams
    on Jun 7, 2023
    Contributor

    CP LGTM

  4. CaseyHillers
    added
    cp: approvedApproved cherry-pick request
    cp: merge-to-stableCherry-picks that should be merged to stable
    on Jun 9, 2023
  5. CaseyHillers
    self-assigned this
    on Jun 9, 2023
  6. CaseyHillers
    added
    cp: mergedCherry-pick has been merged to the release branch.
    on Jun 9, 2023
  7. itsjustkevin
    closed this as completedon Jun 15, 2023

  8. github-actions commented on Jun 29, 2023

    @github-actions
    github-actionsbot
    on Jun 29, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions