Skip to content

PopupMenu Material 3 tokens #128877

Closed

Description

@TahaTesser

Is there an existing issue for this?

Use case

https://github.com/flutter/flutter/blob/master/dev/tools/gen_defaults/data/menu.json seems to be incomplete.

For some reason, I had to hardcode this label style for the popup menu a year ago.

final TextStyle style = _textTheme.labelLarge!;

When looking into #128576, this issue was rediscovered.

https://m3.material.io/components/menus/specs mentions the label large text style.
However, this isn't available in menu tokens or list item tokens.
Screenshot 2023-06-14 at 17 59 03

I can see such a token in Compose https://github.com/androidx/androidx/blob/androidx-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/tokens/MenuTokens.kt

Proposal

If the tokens are missing, add them.

or

Use the list item label token and update M3 web specs to reflect the same.

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    on Jun 14, 2023
  2. TahaTesser commented on Jun 14, 2023

    @TahaTesser
    ContributorAuthor
  3. guidezpl commented on Jun 15, 2023

    @guidezpl
    Member

    I believe v0.164 contains the token, therefore this issue is blocked by #115912

  4. flutter-triage-bot commented on Mar 10, 2024

    @flutter-triage-bot

    This issue is missing a priority label. Please set a priority label when adding the triaged-design label.

  5. added
    P2Important issues not at the top of the work list
    triaged-designTriaged by Design Languages team
    on Mar 13, 2024
  6. 7 remaining items

  7. removed
    ⏳Bot is counting down the days until it unassigns the issue
    on Oct 25, 2024
  8. flutter-triage-bot commented on Mar 5, 2025

    @flutter-triage-bot

    This issue is assigned to @QuncCccccc but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

  9. added
    ⏳Bot is counting down the days until it unassigns the issue
    on Mar 5, 2025
  10. flutter-triage-bot commented on May 21, 2025

    @flutter-triage-bot

    This issue was assigned to @QuncCccccc but has had no status updates in a long time. To remove any ambiguity about whether the issue is being worked on, the assignee was removed.

  11. removed
    ⏳Bot is counting down the days until it unassigns the issue
    on May 21, 2025
  12. QuncCccccc commented on Jun 4, 2025

    @QuncCccccc
    Contributor

    Since the Material3 migration has ended and we've entered the era of Material3 Expressive, I'm closing this issue to avoid introducing more breaking changes.

  13. github-actions commented on Jun 18, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. locked as resolved and limited conversation to collaborators on Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions