Skip to content

[packages] Add a check that "DO NOT MERGE" pubspec changes don't land #129303

Closed
flutter/packages
#6865

Description

@stuartmorgan-g

Our standard workflow for federated changes involves adding dependency overrides with a warning comment via repo tooling; we should have something in CI check that things don't actually land with that. We probably want to put it into federated-safety-check rather than pubspec-check even though the latter would seem to be the natural place for it, since we don't want to have a bunch of different CI failures showing up on the combo PRs, as that makes finding actual problems in the PR harder.

Activity

  1. added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    p: toolingAffects the flutter_plugin_tools package
    packageflutter/packages repository. See also p: labels.
    P2Important issues not at the top of the work list
    on Jun 21, 2023
  2. github-actions commented on Jun 25, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.p: toolingAffects the flutter_plugin_tools packagepackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions