Repository navigation
Change in API docs samples did not trigger tests in presubmit #129390
Copy link
Copy link
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/d: examplesSample code and demosSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure teamOwned by Infrastructure team
Description
Activity
- addeda: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/d: examplesSample code and demosSample code and demosteam-infraOwned by Infrastructure teamOwned by Infrastructure teamP2Important issues not at the top of the work listImportant issues not at the top of the work list
on Jun 22, 2023 This change should have triggered the misc shard, but did not.
I know how to fix, will send PR tomorrow
- added a commit that references this issue
on Jun 23, 2023 This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Jul 7, 2023
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/d: examplesSample code and demosSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure teamOwned by Infrastructure team
Found in #129381
This small change to an API doc sample did not end up executing the sample code tests in presubmit.
Related to #129389, I was looking into why gold did not run for the PR and discovered that on top of that edge case the tests had not actually run either.
https://flutter-gold.skia.org/changelists shows no golden file tests were run for that PR, which would have happened if the tests had run at all.