Skip to content

Change in API docs samples did not trigger tests in presubmit #129390

Description

@Piinks

Found in #129381

This small change to an API doc sample did not end up executing the sample code tests in presubmit.

Related to #129389, I was looking into why gold did not run for the PR and discovered that on top of that edge case the tests had not actually run either.

https://flutter-gold.skia.org/changelists shows no golden file tests were run for that PR, which would have happened if the tests had run at all.

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    frameworkflutter/packages/flutter repository. See also f: labels.
    d: api docsIssues with https://api.flutter.dev/
    team-infraOwned by Infrastructure team
    P2Important issues not at the top of the work list
    on Jun 22, 2023
  2. Piinks commented on Jun 22, 2023

    @Piinks
    ContributorAuthor

    This change should have triggered the misc shard, but did not.

  3. Piinks commented on Jun 22, 2023

    @Piinks
    ContributorAuthor

    I know how to fix, will send PR tomorrow

  4. self-assigned this
    on Jun 23, 2023
  5. github-actions commented on Jul 7, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/d: examplesSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions