Skip to content

[ModalBottomSheet] Allow configuring the max height ratio when isScrollControlled is false #129690

Closed

Description

@AlexV525

Is there an existing issue for this?

Use case

There is a default value when isScrollControlled is false for sheets:

maxHeight: isScrollControlled
? constraints.maxHeight
: constraints.maxHeight * 9.0 / 16.0,

The value is hard-coded and not allowed to be configured. In order to apply custom constraints in the scenario, users must wrap a ConstrainedBox.

Proposal

Expose the value as a parameter scrollControlDisabledMaxHeightRatio for:

  • _BottomSheetLayoutWithSizeListener
  • _RenderBottomSheetLayoutWithSizeListener
  • _ModalBottomSheet
  • ModalBottomSheetRoute
  • showModalBottomSheet

Activity

  1. added
    in triagePresently being triaged by the triage team
    c: new featureNothing broken; request for a new capability
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Jun 28, 2023
  2. added
    P2Important issues not at the top of the work list
    on Jun 29, 2023
  3. added a commit that references this issue on Jul 25, 2023
    9f374f1
  4. added a commit that references this issue on Jul 31, 2023
    70e6b50
  5. added a commit that references this issue on Aug 2, 2023
    258b5e3
  6. github-actions commented on Aug 9, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions