Skip to content

[CP] Allow OverlayPortal to be added/removed from the tree in a layout callback #131002

Closed
Closed
[CP] Allow OverlayPortal to be added/removed from the tree in a layout callback#131002
Assignees
CaseyHillers
Labels
cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Description

@LongCatIsLooong
LongCatIsLooong
opened on Jul 20, 2023

Issue Link

#130668

Commit Hash

bf4d659

Target

beta

PR Link

#130670

Changelog Description

The application asserts when a Tooltip is opened/closed in a layout callback, typically in a LayoutBuilder or when scrolled away in a ListView.

Impacted Users

Tooltip widget users, especially those use it in a ListView

Impact Description

App asserts in debug mode

Workaround

No easy workaround.

Risk

low

Test Coverage

yes

Validation Steps

Either follow the steps provided in #130668, or run the test added in the fix: https://github.com/flutter/flutter/pull/130670/files#diff-d078821c55cd4390761f5928348ab73b271c76edb7c9a440af7edb08ad6896d7

Activity

  1. LongCatIsLooong
    added
    cp: reviewCherry-picks in the review queue
    on Jul 20, 2023
  2. LongCatIsLooong
    assigned
    CaseyHillers
    and
    itsjustkevin
    on Jul 20, 2023

  3. itsjustkevin commented on Jul 21, 2023

    @itsjustkevin
    itsjustkevin
    on Jul 21, 2023
    Contributor

    @HansMuller could you take a look at this cherry-pick request and attach the cp: approved label if you support this cherry-pick?

  4. HansMuller
    added
    cp: approvedApproved cherry-pick request
    on Jul 21, 2023
  5. itsjustkevin
    added
    cp: merge-to-betaCherry-picks that should be merged to beta
    cp: mergedCherry-pick has been merged to the release branch.
    on Jul 25, 2023
  6. CaseyHillers
    assigned
    XilaiZhang
    and unassigned
    CaseyHillers
    and
    itsjustkevin
    on Aug 2, 2023
  7. auto-submit
    added a commit that references this issue on Aug 7, 2023

    [CP] Allow `OverlayPortal` to be added/removed from the tree in a lay…

    5c4bfbc
  8. CaseyHillers
    assigned
    CaseyHillers
    and unassigned
    XilaiZhang
    on Aug 7, 2023

  9. CaseyHillers commented on Aug 14, 2023

    @CaseyHillers
    CaseyHillers
    on Aug 14, 2023
    Contributor

    Shipped in 3.13.0-0.4.pre beta

  10. CaseyHillers
    closed this as completedon Aug 14, 2023

  11. github-actions commented on Aug 28, 2023

    @github-actions
    github-actionsbot
    on Aug 28, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions