Repository navigation
[CP] Fix assertion when a WidgetSpan is scaled by certain textScaleFactor values #131004
Description
Issue Link
Commit Hash
Target
beta
PR Link
Changelog Description
Apps that use WidgetSpans in text widgets may throw an assertion when the text scale factor is set to certain values.
Impacted Users
WidgetSpan users
Impact Description
Apps that use WidgetSpans in text widgets may throw an assertion when the text scale factor is set to certain values, due to floating point precision.
Workaround
No easy workaround available
Risk
low
Test Coverage
yes
Validation Steps
Follow the repro steps in #130588, or run this test: https://github.com/flutter/flutter/pull/130648/files#diff-9fccc94ba0e90a5fb4c5b90761fe59995a5cf7bad0d580c6c2ff3cceafb495e5
Activity
itsjustkevin commentedon Jul 21, 2023
Thanks again for the cherry-pick @LongCatIsLooong, it seems like there may have been an error in the changelog description, could you take a look?
@HansMuller could you take a look at this cherry-pick request and attach the cp: approved label if you support this cherry-pick?
LongCatIsLooong commentedon Aug 4, 2023
Turns out I missed that in
computeDryLayoutand this commit needs to be added too: #131765. @XilaiZhang should I update the CP pull request to include that commit when it's merged, or that deserves its own CP request?XilaiZhang commentedon Aug 4, 2023
yeah it would need another cp request and cp approval. @itsjustkevin are we going to do another hotfix on 3.13.0 next week?
tgucio commentedon Aug 7, 2023
#131765 is now merged into main.
[CP] `_RenderScaledInlineWidget` constrains child size (#130648) (#13…
CaseyHillers commentedon Aug 14, 2023
Shipped in 3.13.0-0.4.pre beta
github-actions commentedon Aug 28, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.