Skip to content

[CP] Constrain _RenderScaledInlineWidget child size in computeDryLayout #132095

Closed

Description

@LongCatIsLooong

Issue Link

#130588

Commit Hash

55044a6

Target

beta

PR Link

#132096

Changelog Description

Address the issue that the previous CP didn't fully resolve: #131289

Impacted Users

WidgetSpan users

Impact Description

Apps that use WidgetSpans in text widgets may throw an assertion when the text scale factor is set to certain values, due to floating point precision.

Workaround

not available

Risk

low

Test Coverage

yes

Validation Steps

Follow the repro steps in #130588

Activity

  1. self-assigned this
    on Aug 7, 2023
  2. CaseyHillers commented on Aug 7, 2023

    @CaseyHillers
    Contributor

    @chunhtai can you review this CP request? If it looks good to you, add the "cp: approved" label.

  3. chunhtai commented on Aug 8, 2023

    @chunhtai
    Contributor

    change seems low risk, approved

  4. CaseyHillers commented on Aug 14, 2023

    @CaseyHillers
    Contributor

    Shipped in 3.13.0-0.4.pre beta

  5. github-actions commented on Aug 28, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions