Skip to content

Clean up commands for analytics opt out #132258

Closed

Description

@eliasyishak

Currently we have two different flags that can be used for disabling analytics collection for the flutter tool. And this is because we currently have two different analytics systems within the flutter tool as we are incrementally migrating to package:unified_analytics

Note: although there are two commands for disabling analytics, they both did the same thing by opting out of the legacy analytics system and from the new package:unified_analytics system.

The legacy analytics system from package:usage used the following commands to enable and disable analytics

flutter config --no-analytics // to disable

flutter config --analytics // to enable

While package:unified_analytics used the following flutter commands to achieve the same results

flutter --disable-telemetry // to disable

flutter --enable-telemetry // to enable

This issue proposes we remove the flutter --disable-telemetry and flutter --enable-telemetry commands in favor of a new command below

flutter --disable-analytics // to disable

flutter --enable-analytics // to enable

Those commands are the same as dart --enable-analytics and dart --disable-analytics and result in less confusion.

Preventing Breaking Changes

The flutter --disable-telemetry and flutter --enable-telemetry are only 2 months old so likely won't break too many clients. However, flutter config --no-analytics and flutter config --analytics will likely break several clients so to prevent this, we will alias the following below.

So running:
flutter --disable-analytics will be an alias for flutter config --no-analytics
flutter --enable-analytics will be an alias for flutter config --analytics

Activity

  1. added
    P2Important issues not at the top of the work list
    team-toolOwned by Flutter Tool team
    on Aug 9, 2023
  2. self-assigned this
    on Aug 9, 2023
  3. eliasyishak commented on Aug 9, 2023

    @eliasyishak
    ContributorAuthor

    fyi @Hixie

  4. Hixie commented on Aug 9, 2023

    @Hixie
    Contributor

    Oh I didn't realize we had three sets of options, oops! :-)

  5. linked a pull request that will close this issueClean up analytics opt in/out flags #132588on Aug 15, 2023
  6. github-actions commented on Sep 26, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listteam-toolOwned by Flutter Tool team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions