Skip to content

Let scrollbars avoid obstructing slivers and media query paddings #13253

Description

@xster

Internal: b/144318472

Consider a CustomScrollView with a SliverAppBar and a SliverList and the user wants a scrollbar showing the position inside the SliverList's contents only.

Let the SliverAppBar report SliverGeometry describing its obstructing and max obstructing extends. Let that get aggregated by the scrollable and bubbled up with a scroll notification so the scrollbar can start below the obstructing area.

Activity

  1. added
    c: new featureNothing broken; request for a new capability
    p: material_uimaterial_ui package in flutter/packages
    f: scrollingViewports, list views, slivers, etc.
    on Nov 29, 2017
  2. added this to the milestone on Nov 29, 2017
  3. changed the title [-]Let scrollbars avoid obstructing slivers[/-] [+]Let scrollbars avoid obstructing slivers and media query paddings[/+] on Nov 30, 2017
  4. xster commented on Nov 30, 2017

    @xster
    MemberAuthor

    Also avoid media query partial obstructions

  5. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Jul 22, 2018
  6. self-assigned this
    on Dec 14, 2018
  7. removed their assignment
    on Feb 23, 2019
  8. xster commented on Jun 3, 2019

    @xster
    MemberAuthor

    This issue isn't closed yet is it? Since there's still the sliver half of it.

  9. LongCatIsLooong commented on Jun 11, 2019

    @LongCatIsLooong
    Contributor

    It was closed because I put partially fixes in my PR.

  10. 11 remaining items

  11. LongCatIsLooong commented on Oct 13, 2020

    @LongCatIsLooong
    Contributor

    @xster no unfortunately.

  12. modified the milestones: 1.24 - October 2020, on Nov 10, 2020
  13. krll-kov commented on Jul 5, 2021

    @krll-kov
    Contributor

    Any progress?

  14. goderbauer commented on Aug 5, 2021

    @goderbauer
    Member

    Also somewhat relevant for #87370 to avoid drawing the scrollbar on top of pinned header rows, for example.

  15. self-assigned this
    on Aug 16, 2021
  16. added
    P1High-priority issues at the top of the work list
    and removed
    P2Important issues not at the top of the work list
    on Sep 14, 2021
  17. CavalcanteLeo commented on Nov 27, 2021

    @CavalcanteLeo

    any progress?

  18. Piinks commented on Mar 8, 2022

    @Piinks
    Contributor

    I have a proposal for this that should be up for review this week.
    I just noticed this is also something the MaterialBanner would want to support. Currently it would overlap a SliverAppBar, just like a Scrollbar does. I need to test this new use case to make sure it works too before pushing the changes.
    I'll probably land the ability to surface this information to these widgets, and then update each widget in a separate follow up change.

  19. Piinks commented on Jul 8, 2022

    @Piinks
    Contributor

    Closing this to consolidate in #107322
    In researching a solution, I found a pattern of the same issue across multiple widgets in the framework. There is a full list in that tracking issue, including scrollbars.

    I have a proposed solution in #107182 that will fix this consistently across all affected parts of the framework. That PR will be split up into multiple PRs to address each widget that needs this fix, just finishing the many test cases now. Please continue to follow in #107322, I expect all of thees changes to be landing soon.

  20. github-actions commented on Jul 22, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  21. locked as resolved and limited conversation to collaborators on Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: new featureNothing broken; request for a new capabilitycustomer: crowdAffects or could affect many people, though not necessarily a specific customer.customer: money (g3)f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesp: material_uimaterial_ui package in flutter/packages

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions