Skip to content

Test fails based on time taken rather than testing the actual condition #133215

Closed
#133229
Closed
Test fails based on time taken rather than testing the actual condition#133215
#133229
Assignees
Hixie
Labels
P1High-priority issues at the top of the work listc: flakeTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.waiting for PR to land (fixed)A fix is in flight

Description

@flar
flar
opened on Aug 23, 2023

In this PR: #132239

A test was added that looks for output that it expects to have "0ms" as the run time. That is not a reliable condition on test hosts and presumably doesn't actually test that the behavior was actually disabled, just that it doesn't take "much" time.

A failure on this test can derail an engine roll as seen here: https://cirrus-ci.com/task/5417897460236288?logs=main#L1130

Activity

  1. flar commented on Aug 23, 2023

    @flar
    flar
    on Aug 23, 2023
    ContributorAuthor

    @Hixie

  2. Hixie commented on Aug 24, 2023

    @Hixie
    Hixie
    on Aug 24, 2023
    Contributor

    hm yeah, i suppose that could go wrong huh

  3. Hixie
    self-assigned this
    on Aug 24, 2023
  4. Hixie
    added
    P1High-priority issues at the top of the work list
    c: flakeTests that sometimes, but not always, incorrectly pass
    toolAffects the "flutter" command-line tool. See also t: labels.
    team-toolOwned by Flutter Tool team
    waiting for PR to land (fixed)A fix is in flight
    on Aug 24, 2023
  5. Hixie
    closed this as completedin #133229on Aug 29, 2023
  6. Hixie
    added a commit that references this issue on Aug 29, 2023

    Use a fake stopwatch to remove flakiness. (#133229)

    89310ed

  7. github-actions commented on Sep 12, 2023

    @github-actions
    github-actionsbot
    on Sep 12, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. github-actions
    locked as resolved and limited conversation to collaborators on Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: flakeTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.waiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions