Skip to content

[packages] Clean up manual Pigeon enum wrappers #133455

Description

@stuartmorgan-g

Now that #87307 is implemented we should update packages that had manual wrappers to work around it. Looking for references to 87307 in the codebase, it looks like that's:

  • local_auth_android
  • local_auth_ios
  • webview_flutter_android
  • webview_flutter_wkwebview

/cc @tarrinneal in case you want to do this as a follow-up.

Activity

  1. added
    p: local_authPlugin for local authentification
    packageflutter/packages repository. See also p: labels.
    P2Important issues not at the top of the work list
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Aug 28, 2023
  2. tarrinneal commented on Aug 30, 2023

    @tarrinneal
    Contributor

    local_auth_ios requires List<Enum> which isn't supported yet.

  3. tarrinneal commented on Aug 31, 2023

    @tarrinneal
    Contributor

    webview_flutter_wkwebview also requires List<Enum> I am updating the primitives to remove the classes.

  4. stuartmorgan-g commented on Aug 31, 2023

    @stuartmorgan-g
    ContributorAuthor

    Since I filed this just to make sure we tracked actually using the new functionality that we had, we can go ahead and close this given that the remaining work is still blocked. We can file a new issue once #133728 is fixed.

  5. github-actions commented on Sep 14, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Sep 14, 2023
  7. tarrinneal commented on Aug 30, 2024

    @tarrinneal
    Contributor

    now that flutter/packages#7476 has landed, the rest of these can be fixed as well.

  8. unlocked this conversation on Sep 1, 2024
  9. stuartmorgan-g commented on Oct 1, 2024

    @stuartmorgan-g
    ContributorAuthor

    @bparrishMines Assign to you since the last one to update is webview_flutter_wkwebview, which should be done as part of switching to the new proxy generator.

  10. flutter-triage-bot commented on Feb 4, 2025

    @flutter-triage-bot

    This issue is assigned to @bparrishMines but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

  11. added
    ⏳Bot is counting down the days until it unassigns the issue
    on Feb 4, 2025
  12. stuartmorgan-g commented on Feb 5, 2025

    @stuartmorgan-g
    ContributorAuthor

    This is done.

  13. github-actions commented on Feb 19, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. locked as resolved and limited conversation to collaborators on Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

⏳Bot is counting down the days until it unassigns the issueP2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.p: local_authPlugin for local authentificationp: webviewThe WebView pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions