Skip to content

[CP] 3.14: [Impeller] Apply color blends on the CPU; fix mask blurs and the Gaussian blur coverage hint. #133511

Closed

Description

@bdero

Issue Link

#132936

Commit Hash

flutter-team-archive/engine@53595c9

Target

beta

PR Link

flutter-team-archive/engine#45193

Changelog Description

Fixes issues in the generic mask blurring path as well as geometry coordinate mapping problems in the Gaussian blur.

Impacted Users

This issue affects Impeller users.

Impact Description

This fixes a variety of rendering problems with Impeller shadows which are exacerbated by the presence of dirty regions. When elements are moving over the top of a non-animated shadow, the shadow may sometimes render as faded or become invisible.

Workaround

There are no simple workaround for this issue.

Risk

medium

Test Coverage

yes

Validation Steps

To test, run the example Flutter app in #132936 and verify that the blur does not cut out while scrolling.
Alternatively, run the AiksTest.ClippedBlurFilterRendersCorrectly playground golden and verify that the blur does not dim out as it approaches the top edge of the screen.

Activity

  1. itsjustkevin commented on Aug 28, 2023

    @itsjustkevin
    Contributor

    @zanderso could you review this cherry-pick?

  2. zanderso commented on Aug 28, 2023

    @zanderso
    Member

    cp lgtm

  3. added
    cp: mergedCherry-pick has been merged to the release branch.
    on Aug 31, 2023
  4. bdero commented on Sep 1, 2023

    @bdero
    MemberAuthor

    Should we close this as complete, or are there more steps from here?

  5. itsjustkevin commented on Sep 1, 2023

    @itsjustkevin
    Contributor

    @bdero the release engineer will close this issue when it is released.

  6. github-actions commented on Sep 15, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions