Skip to content

Clean up use of instanceof in integration_test #134252

Open
Open
Clean up use of instanceof in integration_test#134252
Labels
P2Important issues not at the top of the work listplatform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

Description

@gmackall
gmackall
opened on Sep 7, 2023

Currently we are differentiating between a FlutterActivity and a FlutterFragmentActivity with instanceof. We should find a better way to differentiate, or more generally to get the flutter view in FlutterDeviceScreenshot.

Context
https://github.com/flutter/flutter/pull/132406/files#r1313387041
go/UnhealthyIdioms#awkward-inheritance-hierarchy

Activity

  1. gmackall
    added
    platform-androidAndroid applications specifically
    team-androidOwned by Android platform team
    P2Important issues not at the top of the work list
    triaged-androidTriaged by Android platform team
    on Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listplatform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions