You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
--dart-define-from-file tests are spread across two unrelated files #134279
We have tests related to the --dart-define-from-file option in both build_bundle_test.dart and assemble_test.dart. This option does not function differently under these the flutter build bundle and flutter assemble commands, so it would make more sense to group all of these tests together into flutter_command.dart, where the --dart-define-from-file functionality is implemented.
In addition, there are some things about these tests that we should fix:
There are multiple tests that make sure we tool exit when --dart-define-from-file is given a malformed file (e.g. invalid JSON). Their titles don't differentiate themselves from each other, which can be confusing. These tests should either be merged into a single test call or be given better names and be grouped together into a group.
Nit: Some tests could have better names. The names state what is under test, but not what the expected result is.
Lastly, while this is not related to the tests, we probably should change the error message printed when the user provides malformed JSON. Currently, we yell at the user.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
clean up `--dart-define-from-file` option tests (#135980)
github-actions commentedon Oct 31, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.