Skip to content

Documentation on gathering engine treemaps is out-of-date. #136011

Closed

Description

@chinmaygarde

https://github.com/flutter/flutter/wiki/Engine-disk-footprint#treemaps points to guidance on how to generate treemaps of the Flutter Engine. This used to work at some point. See https://storage.googleapis.com/flutter_infra_release/flutter/12def739b1f63ccaf5b859714d9f552e9e6fe348/android-arm64-release/sizes/index.html. However, it no longer works for recent engine commits. See https://storage.googleapis.com/flutter_infra_release/flutter/4d1f8ff52903dc94574397228597488ec8c089d7/android-arm64-release/sizes/index.html (the SHA is the latest engine.version in framework as of this writing).

Activity

  1. zanderso commented on Oct 6, 2023

    @zanderso
    Member

    From the LUCI build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/399194/overview

    I can find the link

    https://storage.googleapis.com/flutter_logs/flutter/59b6b94e1a5168ddb77315df788a80fe0c094ecd/Generate%20treemap%20for%20android_release_arm64/ddca6da8-ee63-49c3-9b88-359456fb59e9/index.html

    Which we could use to update the wiki page, but I don't know why the ddca6da8-ee63-49c3-9b88-359456fb59e9 component is there. @godofredoc do you know what that part is, or if we can get rid of it somehow so that we can go back to deriving the link from only the variant and commit hash?

  2. added
    P1High-priority issues at the top of the work list
    on Oct 9, 2023
  3. flutter-triage-bot commented on Feb 28, 2024

    @flutter-triage-bot

    This issue is marked P1 but has had no recent status updates.

    The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

    Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

  4. added
    P2Important issues not at the top of the work list
    and removed
    P1High-priority issues at the top of the work list
    on Feb 28, 2024
  5. jtmcdole commented on May 5, 2025

    @jtmcdole
    Member

    https://storage.googleapis.com/flutter_logs/flutter/59b6b94e1a5168ddb77315df788a80fe0c094ecd/Generate%20treemap%20for%20android_release_arm64/ddca6da8-ee63-49c3-9b88-359456fb59e9/index.html

    Which we could use to update the wiki page, but I don't know why the ddca6da8-ee63-49c3-9b88-359456fb59e9 component is there. @godofredoc do you know what that part is, or if we can get rid of it somehow so that we can go back to deriving the link from only the variant and commit hash?

    From the commit message:

    We also changed the logs destination to include task name an a uuid to ensure logs are not clashing.

    We actually upload to two locations. First, for the subtest:

    Running the following only lists one folder (the UUID).

    $ gsutil ls gs://flutter_logs/flutter/78a2a3fa675572fe55b2aa47e2ff1317baf30d03/Generate\ treemap\ for\ android_release_arm64
    gs://flutter_logs/flutter/78a2a3fa675572fe55b2aa47e2ff1317baf30d03/Generate treemap for android_release_arm64/999fceb0-1148-4ab2-94c6-da78813f228d/
    

    And then a second time at the end, which includes all builders for the sha:

    gsutil ls gs://flutter_logs/engine/78a2a3fa675572fe55b2aa47e2ff1317baf30d03/builder | wc -l
         191
    

    Sadly, this is a new UUID rather than the first one (999fceb0-1148-4ab2-94c6-da78813f228d).

    Potential solution: Add a field to the task that would include two pieces of information: "android_release_arm64" & "sizes" and pull those out in builder.py run_tests and pass them in as the task and new "key" field to upload_logs.

    So linux_android_aot_engine.json would look like:

                "tests": [
                    {
                        "name": "Generate treemap for android_release_arm64",
                        "language": "bash",
                        "script": "flutter/ci/binary_size_treemap.sh",
                        "parameters": [
                            "../../src/out/ci/android_release_arm64/libflutter.so",
                            "${FLUTTER_LOGS_DIR}"
                        ],
                       "upload_logs": {"name": "android_release_arm64", "key": "sizes"}
                    }
                ]
  6. self-assigned this
    on May 5, 2025
  7. jtmcdole commented on May 5, 2025

    @jtmcdole
    Member
  8. added a commit that references this issue on May 5, 2025
    31a6d10
  9. added a commit that references this issue on May 6, 2025
    429d7e8
  10. added a commit that references this issue on May 6, 2025
    523427d
  11. github-actions commented on May 20, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. locked as resolved and limited conversation to collaborators on May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listd: wikiFlutter or engine wikisteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions