Skip to content

[CP] Correct warning for compatible Java versions range given template AGP & Gradle versions #136388

Closed
Closed
[CP] Correct warning for compatible Java versions range given template AGP & Gradle versions#136388
Assignees
CaseyHillersitsjustkevin
Labels
cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Description

@camsim99
camsim99
opened on Oct 11, 2023

Issue Link

#135710 has a description of the problem (I don't have one but I can open one if needed)

Commit Hash

54cf286

Target

beta

PR Link

#135710 #136766

Changelog Description

Corrects the range of Java versions that flutter create will show if your Java version is incompatible with Flutter's template AGP & Gradle versions and/or is too new/old a version to be recognized by Flutter's tooling.

The range currently printed suggests that the upper bound is inclusive, whereas it is exclusive, so it may confuse developers.

Impacted Users

All Flutter devs running flutter create for something running on Android

Impact Description

They will see a range of Java versions that is confusing. It can easily be found out as incorrect by following documentation linked in the warning, but we can't guarantee devs will look there to confirm the range of Java versions that we suggest.

Workaround

Following the documentation linked in the warning to check the Java versions.

Risk

low

Test Coverage

yes

Validation Steps

There are many tests that prove that the range is exclusive (

flutter/packages/flutter_tools/test/general.shard/android/gradle_utils_test.dart

Line 945 in a047358

testWithoutContext('getJavaVersionFor returns expected Java version range', () {
). I just forgot to format the warning appropriately in #131444, where I added the warning.

Activity

  1. camsim99
    added
    cp: reviewCherry-picks in the review queue
    on Oct 11, 2023
  2. camsim99
    assigned
    CaseyHillers
    and
    itsjustkevin
    on Oct 11, 2023

  3. itsjustkevin commented on Oct 17, 2023

    @itsjustkevin
    itsjustkevin
    on Oct 17, 2023
    Contributor

    @reidbaker could you take a look at this cherry-pick and attach the cp: approved label if you agree?

  4. itsjustkevin
    added
    cp: merge-to-stableCherry-picks that should be merged to stable
    on Oct 17, 2023

  5. itsjustkevin commented on Oct 17, 2023

    @itsjustkevin
    itsjustkevin
    on Oct 17, 2023
    Contributor

    @camsim99 can you link the cherry-pick PR you created?

  6. reidbaker
    added
    cp: approvedApproved cherry-pick request
    on Oct 17, 2023

  7. reidbaker commented on Oct 17, 2023

    @reidbaker
    reidbaker
    on Oct 17, 2023
    Contributor

    Labels added for approval.

  8. camsim99 commented on Oct 17, 2023

    @camsim99
    camsim99
    on Oct 17, 2023
    ContributorAuthor

    @camsim99 can you link the cherry-pick PR you created?

    #135710 #136766

  9. itsjustkevin
    added
    cp: mergedCherry-pick has been merged to the release branch.
    on Oct 18, 2023
  10. auto-submit
    added a commit that references this issue on Oct 18, 2023

    [CP][Android] Update Java/AGP/Gradle warning compatible Java range (#…

    f00b8f5
  11. itsjustkevin
    added a commit that references this issue on Oct 18, 2023

    [flutter_releases] Flutter stable 3.13.8 Framework Cherrypicks (#136815)

    6c4930c
  12. itsjustkevin
    added
    cp: merge-to-betaCherry-picks that should be merged to beta
    and removed
    cp: merge-to-stableCherry-picks that should be merged to stable
    on Oct 18, 2023
  13. itsjustkevin
    closed this as completedon Oct 24, 2023

  14. github-actions commented on Nov 7, 2023

    @github-actions
    github-actionsbot
    on Nov 7, 2023 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  15. github-actions
    locked as resolved and limited conversation to collaborators on Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions