Material page transition is slow when we enable fade #13736

Activity

1. Hixie

   added

   c: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   c: regressionIt was better in the past than it is nowIt was better in the past than it is now

   on Dec 21, 2017
2. Hixie

   added this to the 3: Current Milestone milestone on Dec 21, 2017
3. Hixie

   self-assigned this

   on Dec 21, 2017
4. Hixie commented on Jan 18, 2018

   

   Hixie

   on Jan 18, 2018

   ContributorAuthor

   More actions

   Specifically, this seems to cause a ~2x regression on the GPU side.
   See flutter_gallery__transition_perf average_frame_rasterizer_time_millis around 2017-12-20.
5. Hixie commented on Jan 20, 2018

   

   Hixie

   on Jan 20, 2018

   ContributorAuthor

   More actions

   Here's what it looks like on Nexus 5 today:

   MaterialPageRoute.debugEnableFadingRoutes = false
   

   MaterialPageRoute.debugEnableFadingRoutes = true
   
6. Hixie

   removed their assignment

   on Jan 20, 2018
7. Hixie

   added

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   and removed

   c: regressionIt was better in the past than it is nowIt was better in the past than it is now

   on Jan 20, 2018
8. Hixie

   assigned

   cbracken

   on Jan 20, 2018
9. Hixie commented on Jan 20, 2018

   

   Hixie

   on Jan 20, 2018

   ContributorAuthor

   More actions

   cc @cbracken and @chinmaygarde for the engine side. @abarth was suggesting one trick we could use is noticing that a particular layer hasn't changed from frame to frame and not redrawing it when we change the opacity, or some such; I forget the precise details.
10. abarth commented on Jan 20, 2018

    

    abarth

    on Jan 20, 2018

    Contributor

    More actions

    The idea is to be able to cache intermediate layers (in this case the one that gets blended back into the main buffer) rather than just leaves as we do today.

    The framework could take each layer with a unique id (similar to the unique id we use for SkPicture). The compositor could then notice with a subtree had the same id as before and consider caching it.
11. Hixie

    modified the milestones: 3: Current Milestone, 4: Next milestoneThis milestone has been deleted on Jan 26, 2018
12. 70 remaining items

    Load more

13. Hixie commented on Jul 16, 2018

    

    Hixie

    on Jul 16, 2018

    ContributorAuthor

    More actions

    This continues to be our top priority for 1.0; we're not stalled, just working hard. :-)

    👍React with 👍4Reacted by Vid Klopcic, Itay Ganor, Wesley Fantinel and thezjy

    ❤️React with ❤️13Reacted by Carson Holzheimer, Dave Macaulay, Phuc Dam, Luca Romagnoli, Stanislas Signoud, Jake Gough, Paolo Rotolo, Khalifa Visi Islami, Vid Klopcic, Cretezy and 3 more
14. Hixie

    modified the milestones: bucket6, bucket8, bucket9 on Jul 17, 2018
15. najeira

    added a commit that references this issue on Jul 19, 2018

    Remove unnecessary saveLayer (flutter-team-archive#5420)

    ...

    This issue will close once commit 200bd06 is merged into the 'master' branch.

    200bd06
16. zoechi

    added

    frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

    on Jul 22, 2018
17. Hixie commented on Sep 25, 2018

    

    Hixie

    on Sep 25, 2018

    ContributorAuthor

    More actions

    I'm closing this for now. The remaining work will be tracked in #21756.
18. Hixie

    closed this as completedon Sep 25, 2018
19. github-actions commented on Sep 1, 2021

    

    github-actionsbot

    on Sep 1, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
20. github-actions

    locked as resolved and limited conversation to collaborators on Sep 1, 2021
21. zhongdaiqi

    added a commit that references this issue on Oct 9, 2026

    Remove unnecessary saveLayer (flutter-team-archive/engine#5420)

    ...

    This issue will close once commit 949ece5 is merged into the '3.22.0-ohos' branch.

    949ece5