Skip to content

[flutter_tools] _TypeError in IntelliJValidatorOnMac.installed #138029

Closed
#138095
Closed
[flutter_tools] _TypeError in IntelliJValidatorOnMac.installed#138029
#138095
Assignees
andrewkolos
Labels
P1High-priority issues at the top of the work listteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool team

Description

@christopherfujino
christopherfujino
opened on Nov 7, 2023

on beta/3.16.0-0.4.pre

_TypeError: type 'Null' is not a subtype of type 'String' in type cast
at IntelliJValidatorOnMac.installed.<anonymous closure>(intellij_validator.dart:496)
at ListBase._filter(list.dart:293)
at ListBase.removeWhere(list.dart:281)
at IntelliJValidatorOnMac.installed(intellij_validator.dart:489)
at IntelliJValidator.installedValidators(intellij_validator.dart:74)
at _DefaultDoctorValidatorsProvider.validators(doctor.dart:112)
at Doctor.validators(doctor.dart:237)
at Doctor.startValidatorTasks(doctor.dart:243)
at Doctor.diagnose(doctor.dart:378)
at DoctorCommand.runCommand(doctor.dart:49)
at FlutterCommand.verifyThenRunCommand(flutter_command.dart:1662)
at <asynchronous gap>(async)
at FlutterCommand.run.<anonymous closure>(flutter_command.dart:1350)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at CommandRunner.runCommand(command_runner.dart:212)
at <asynchronous gap>(async)
at FlutterCommandRunner.runCommand.<anonymous closure>(flutter_command_runner.dart:348)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at FlutterCommandRunner.runCommand(flutter_command_runner.dart:294)
at <asynchronous gap>(async)
at run.<anonymous closure>.<anonymous closure>(runner.dart:112)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at main(executable.dart:90)
at <asynchronous gap>(async)

cast to string here introduced in #129030

Activity

  1. christopherfujino
    assigned
    christopherfujino
    and unassigned
    christopherfujino
    on Nov 7, 2023
  2. christopherfujino
    added
    team-toolOwned by Flutter Tool team
    toolAffects the "flutter" command-line tool. See also t: labels.
    triaged-toolTriaged by Flutter Tool team
    P1High-priority issues at the top of the work list
    on Nov 7, 2023
  3. christopherfujino
    assigned
    andrewkolos
    on Nov 7, 2023

  4. andrewkolos commented on Nov 8, 2023

    @andrewkolos
    andrewkolos
    on Nov 8, 2023
    Contributor

    @christopherfujino From the CFBundleIdentifier documentation, the field is required, so it's possible that we are dealing with an invalid plist file here (barring some subtle bug in our parser code).

    Anyway, since this code is just meant to avoid duplicate IntelliJ/Android Studio installs, it's probably safe to catch and ignore this error. In the worse case, we might accidentally reintroduce #98276. What do you think?

  5. christopherfujino commented on Nov 8, 2023

    @christopherfujino
    christopherfujino
    on Nov 8, 2023
    ContributorAuthor

    @christopherfujino From the CFBundleIdentifier documentation, the field is required, so it's possible that we are dealing with an invalid plist file here (barring some subtle bug in our parser code).

    Anyway, since this code is just meant to avoid duplicate IntelliJ/Android Studio installs, it's probably safe to catch and ignore this error. In the worse case, we might accidentally reintroduce #98276. What do you think?

    SGTM and LGTM on the PR

  6. auto-submit
    closed this as completedin #138095on Nov 9, 2023
  7. auto-submit
    added a commit that references this issue on Nov 9, 2023

    prevent tool crash when `IntelliJValidatorOnMac` encounters an instal…

    94550c6

  8. github-actions commented on Nov 23, 2023

    @github-actions
    github-actionsbot
    on Nov 23, 2023 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions