[tool_crash] _TypeError: (#0 AppResourceBundle.translationFor (package:flutter_tools/src/localizations/gen_l10n_types.dart:637:70)) #138297

Activity

1. danagbemava-nc

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Nov 13, 2023
2. danagbemava-nc commented on Nov 13, 2023

   

   danagbemava-nc

   on Nov 13, 2023

   Member

   More actions

   Labeling based on the report above.
3. danagbemava-nc

   added

   c: crashStack traces logged to the consoleStack traces logged to the console

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   a: internationalizationSupporting other languages or locales. (aka i18n)Supporting other languages or locales. (aka i18n)

   team-toolOwned by Flutter Tool teamOwned by Flutter Tool team

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Nov 13, 2023
4. christopherfujino

   assigned

   andrewkolos

   on Nov 14, 2023
5. Meshavegas commented on Nov 15, 2023

   

   Meshavegas

   on Nov 15, 2023

   Author

   More actions

   Thank you but i solved it. :)
6. Meshavegas

   closed this as completedon Nov 15, 2023
7. andrewkolos commented on Nov 15, 2023

   

   andrewkolos

   on Nov 15, 2023

   Contributor

   More actions

   Thank you but i solved it. :)

   @Meshavegas, I'm glad you were able solve whatever was causing this crash 🙂. Still, the flutter CLI tool should never crash, which probably means you encountered a bug. I would like to find that bug. If you are willing and able, could you share what was causing this crash?
8. andrewkolos

   reopened this on Nov 15, 2023
9. Meshavegas commented on Nov 16, 2023

   

   Meshavegas

   on Nov 16, 2023

   Author

   More actions

   Thank you but i solved it. :)

   @Meshavegas, I'm glad you were able solve whatever was causing this crash 🙂. Still, the flutter CLI tool should never crash, which probably means you encountered a bug. I would like to find that bug. If you are willing and able, could you share what was causing this crash?

   It appears that the Flutter CLI crash i encountered might have been triggered by a shortage of disk space on my computer. I point out that the substantial resources consumption by Android Studio, when in use, could be a contributing factor to the Flutter CLI crash.

   In summary, my hypothesis is that the insufficient disk space, potentially exacerbated by the resource demands of Android Studio, could have led to the instability of the Flutter CLI.
   I solved the issue by either freeing up space and upgrading my storage capacity might be a practical step to mitigate such problems in the future.
10. andrewkolos commented on Nov 27, 2023

    

    andrewkolos

    on Nov 27, 2023

    Contributor

    More actions

    I've finally done some digging here. Here's what I found.

    My reading of the stack trace:

    • #⁠8: LocalizationsGenerator.loadResources: During build, we read the app's arb files (each of which contains JSON containing resource-value pairs for various locales).
    • #⁠2/#⁠1: Per each resourceId (key) in the template ARB file, we look for a corresponding entry in the rest of the ARB files.
      Here's the line where the TypeError happens:
    • #⁠0: AppResourceBundle.translationFor: in one of those ARB files, we lookup the translation for the given resourceId from a Map<String, Object?>. We try to cast this to a String?. Here is that line of code:

    flutter/packages/flutter_tools/lib/src/localizations/gen_l10n_types.dart

    Line 637 in ff838bc

    String? translationFor(String resourceId) => resources[resourceId] as String?;

    The indexing operation here shouldn't result in a TypeError, so I'm thinking that resources[resourceId] must be non-null and also not a String. resources is generated during the construction of the AppResourceBundle by a simple json.decode operation, and I don't see any code that could overwrite any values. This leads me to believe that flutter was trying to work with an invalid ARB file. To test this, I tried making a minimal repro, and I was successful.

    1. Create a copy of the Flutter website's gen_l10n_example.
    2. In lib/l10n/app_es.arb, change the helloWorld entry's value from "¡Hola Mundo!" to {}.
    3. flutter clean and flutter pub get (which will run flutter gen_l10n).

    This resulted in a crash containing a link to create a new GitHub issue that looked identical to this issue. Here is my stack trace:

    Details

    _TypeError: (#0 AppResourceBundle.translationFor (package:flutter_tools/src/localizations/gen_l10n_types.dart:649:70))

    #0      AppResourceBundle.translationFor (package:flutter_tools/src/localizations/gen_l10n_types.dart:649:70)
    #1      new Message (package:flutter_tools/src/localizations/gen_l10n_types.dart:354:42)
    #2      LocalizationsGenerator.loadResources.<anonymous closure> (package:flutter_tools/src/localizations/gen_l10n.dart:913:67)
    #3      MappedIterator.moveNext (dart:_internal/iterable.dart:403:20)
    #4      new _GrowableList._ofOther (dart:core-patch/growable_array.dart:202:26)
    #5      new _GrowableList.of (dart:core-patch/growable_array.dart:152:26)
    #6      new List.of (dart:core-patch/array_patch.dart:39:18)
    #7      Iterable.toList (dart:core/iterable.dart:497:7)
    #8      LocalizationsGenerator.loadResources (package:flutter_tools/src/localizations/gen_l10n.dart:921:8)
    #9      generateLocalizations (package:flutter_tools/src/localizations/gen_l10n.dart:77:9)
    #10     GenerateLocalizationsTarget.build (package:flutter_tools/src/build_system/targets/localizations.dart:60:11)
    #11     _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:853:27)
    <asynchronous suspension>
    #12     FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:620:16)
    <asynchronous suspension>
    #13     generateLocalizationsSyntheticPackage (package:flutter_tools/src/dart/generate_synthetic_packages.dart:56:30)
    <asynchronous suspension>
    #14     PackagesGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:305:9)
    <asynchronous suspension>
    #15     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1388:27)
    <asynchronous suspension>
    #16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
    <asynchronous suspension>
    #17     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
    <asynchronous suspension>
    

    In conclusion, when parsing arb files, flutter should also validate the contents. If the contents are invalid, we it throw a ToolExit with a helpful message instead of crashing. I've opened #139035 to do this
11. auto-submit

    closed this as completedin #139035on Nov 27, 2023
12. auto-submit

    added a commit that references this issue on Nov 27, 2023

    Add type validation to non-template .arb file parsing logic (#139035)

    ...

    1952a6c
13. danagbemava-nc

    added

    r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version

    on Nov 28, 2023
14. github-actions commented on Dec 12, 2023

    

    github-actionsbot

    on Dec 12, 2023 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
15. github-actions

    locked as resolved and limited conversation to collaborators on Dec 12, 2023
16. caseycrogers

    added a commit that references this issue on Dec 29, 2023

    Add type validation to non-template .arb file parsing logic (flutter#…

    ...

    ba9ef40