Skip to content

20% regression in platform channels benchmark #138689

Closed
Closed
20% regression in platform channels benchmark#138689
Assignees
sstrickl
Labels
P1High-priority issues at the top of the work listc: performanceRelates to speed or footprint issues (see "perf:" labels)dependency: dartDart team may need to help usteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@zanderso
zanderso
opened on Nov 19, 2023

On the engine roll #138647, SkiaPerf is reporting a ~20% regression in the platform_channel_basic_standard_2host_large metric from the platform_channels_benchmarks benchmark:

https://flutter-flutter-perf.skia.org/e/?begin=1700183293&end=1700312483&keys=X25251bae98644a72a9a678545659f5cc&num_commits=50&request_type=1&xbaroffset=38025

That Engine -> Dart roll has a Dart SDK roll (flutter-team-archive/engine#48187), and from that roll, the following commit looks like it could be related:

https://dart.googlesource.com/sdk.git/+/904354f108818630c98ef5d019bc0a99e1c6f2fd

cc @gaaclarke @sstrickl @mkustermann

Activity

  1. zanderso
    added
    c: performanceRelates to speed or footprint issues (see "perf:" labels)
    dependency: dartDart team may need to help us
    team-engineOwned by Engine team
    on Nov 19, 2023

  2. mkustermann commented on Nov 20, 2023

    @mkustermann
    mkustermann
    on Nov 20, 2023
    Member

    We also saw a regression from golem (as well as many improvements). I think @sstrickl is looking into this.

  3. mkustermann
    assigned
    sstrickl
    on Nov 20, 2023

  4. sstrickl commented on Nov 20, 2023

    @sstrickl
    sstrickl
    on Nov 20, 2023
    Contributor

    Yes, investigating now.

  5. zanderso commented on Nov 20, 2023

    @zanderso
    zanderso
    on Nov 20, 2023
    MemberAuthor

    Yes, Moto G4 is 32-bit.

  6. jonahwilliams
    added
    P1High-priority issues at the top of the work list
    triaged-engineTriaged by Engine team
    on Nov 20, 2023
  7. copybara-service
    added a commit that references this issue on Nov 21, 2023

    [vm/compiler] On 32-bit archs, no specific inline for index checks.

    26911a6
  8. zanderso
    added 2 commits that reference this issue on Nov 27, 2023

    Run platform_channels_benchmarks on Pixel 7 Pro

    9ee1e9d

    Run platform_channels_benchmarks on Pixel 7 Pro (#139092)

    e49cc81

  9. zanderso commented on Nov 28, 2023

    @zanderso
    zanderso
    on Nov 28, 2023
    MemberAuthor

    This is resolved

  10. zanderso
    closed this as completedon Nov 28, 2023

  11. github-actions commented on Dec 12, 2023

    @github-actions
    github-actionsbot
    on Dec 12, 2023 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: performanceRelates to speed or footprint issues (see "perf:" labels)dependency: dartDart team may need to help usteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions