Skip to content

Enable regular validation for leaks in Flutter Framework. #138741

Closed
Closed
Enable regular validation for leaks in Flutter Framework.#138741
Labels
P2Important issues not at the top of the work lista: leak trackingIssues and PRs related to memory leaks detected by leak_trackera: tests"flutter test", flutter_test, or one of our testsc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.r: duplicateIssue is closed as a duplicate of an existing issueteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

Description

@polina-c
polina-c
opened on Nov 20, 2023

This PR adds flag to turn leak tracking on/off for flutter tests: #138653

Leak tracking is off by default till prove of its stability.

To prove leak tracker stability we need a signal about leak related failures on master. Ideally, after each PR. If it not possible, just regular execution of flutter tests with flag enabled.

This would be command to run in flutter/packages/flutter:

flutter test --dart-define=flutter_test_config.leak_tracking=true

Ideally I would like to see output of three types:

  1. (green) Tests passed
  2. (red) Tests failed and there is text Which: contains leaks: in stdout
  3. (yellow) Test failed without text Which: contains leaks: in stdout

For example, it can be just email with color in the subject, like:

leak_traker report after merge of PR 123: green

I am open for any trade offs and adjustments, to make it compliant with prior art add to make it easier to configure..

Activity

  1. polina-c commented on Nov 20, 2023

    @polina-c
    polina-c
    on Nov 20, 2023
    ContributorAuthor

    @godofredoc , created this issue as we discussed

  2. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: proposalA detailed proposal for a change to Flutter
    team-infraOwned by Infrastructure team
    a: leak trackingIssues and PRs related to memory leaks detected by leak_tracker
    a: tests"flutter test", flutter_test, or one of our tests
    team-frameworkOwned by Framework team
    and removed
    in triagePresently being triaged by the triage team
    team-infraOwned by Infrastructure team
    on Nov 21, 2023
  3. goderbauer
    changed the title [-]Enable regular validation for reaks in Flutter Framework.[/-] [+]Enable regular validation for leaks in Flutter Framework.[/+] on Nov 21, 2023
  4. goderbauer
    added
    team-infraOwned by Infrastructure team
    and removed
    team-frameworkOwned by Framework team
    on Nov 21, 2023
  5. keyonghan
    added
    P0Critical issues such as a build break or regression
    triaged-infraTriaged by Infrastructure team
    P2Important issues not at the top of the work list
    and removed
    P0Critical issues such as a build break or regression
    on Nov 30, 2023

  6. polina-c commented on Dec 20, 2023

    @polina-c
    polina-c
    on Dec 20, 2023
    ContributorAuthor

    Closing in favor of #140414

  7. polina-c
    closed this as completedon Dec 20, 2023
  8. danagbemava-nc
    added
    r: duplicateIssue is closed as a duplicate of an existing issue
    on Dec 21, 2023

  9. github-actions commented on Jan 4, 2024

    @github-actions
    github-actionsbot
    on Jan 4, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. github-actions
    locked as resolved and limited conversation to collaborators on Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: leak trackingIssues and PRs related to memory leaks detected by leak_trackera: tests"flutter test", flutter_test, or one of our testsc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.r: duplicateIssue is closed as a duplicate of an existing issueteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions