Skip to content

InkSparkle should always have fixed turbulence in debug mode #138753

Closed
#138757
Closed
InkSparkle should always have fixed turbulence in debug mode#138753
#138757
Assignees
Piinks
Labels
a: tests"flutter test", flutter_test, or one of our testsframeworkflutter/packages/flutter repository. See also f: labels.team-designOwned by Design Languages teamwaiting for PR to land (fixed)A fix is in flight

Description

@Piinks
Piinks
opened on Nov 20, 2023

We've had a lot of test flakes due to this. It would be good to have a default fixed seed for debug builds.

Activity

  1. Piinks
    self-assigned this
    on Nov 20, 2023
  2. Piinks
    added
    team-designOwned by Design Languages team
    a: tests"flutter test", flutter_test, or one of our tests
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Nov 20, 2023

  3. Piinks commented on Nov 20, 2023

    @Piinks
    Piinks
    on Nov 20, 2023
    ContributorAuthor

    cc @bleroux @TahaTesser

  4. Piinks commented on Nov 20, 2023

    @Piinks
    Piinks
    on Nov 20, 2023
    ContributorAuthor

    I should have a PR momentarily

  5. TahaTesser commented on Nov 20, 2023

    @TahaTesser
    TahaTesser
    on Nov 20, 2023
    Contributor

    Excellent idea!

  6. Piinks
    added
    waiting for PR to land (fixed)A fix is in flight
    on Nov 20, 2023
  7. auto-submit
    closed this as completedin #138757on Nov 28, 2023
  8. auto-submit
    added a commit that references this issue on Nov 28, 2023

    Fix turbulence seed for all tests with ink sparkles (#138757)

    92ad558

  9. github-actions commented on Dec 12, 2023

    @github-actions
    github-actionsbot
    on Dec 12, 2023 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. github-actions
    locked as resolved and limited conversation to collaborators on Dec 12, 2023
  11. caseycrogers
    added a commit that references this issue on Dec 29, 2023

    Fix turbulence seed for all tests with ink sparkles (flutter#138757)

    7e69771
  12. chunhtai
    added a commit that references this issue on Jun 12, 2026

    Fix turbulence seed for all tests with ink sparkles (#138757)

    8a41a8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsframeworkflutter/packages/flutter repository. See also f: labels.team-designOwned by Design Languages teamwaiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions