Skip to content

[google_identity_services_web] migrate to pkg:web #139167

Closed
flutter/packages
#5581

Description

@kevmoo

Required to support wasm compilation

Currently blocking migration of the Flutter Dashboard to Flutter wasm compilation

Activity

  1. added
    p: google_identity_services_webA JS-interop layer for Google Identity's Sign In With Google SDK
    platform-webWeb applications specifically
    e: wasmIssues related to the wasm build of Flutter Web.
    on Nov 28, 2023
  2. added
    packageflutter/packages repository. See also p: labels.
    team-webOwned by Web platform team
    on Nov 30, 2023
  3. ditman commented on Dec 1, 2023

    @ditman
    Member

    I wrote google_identity_services_web a long time ago, but with staticInterop and all that jazz, this shouldn't be using dart:html and friends. How can I verify that I've successfully written/migrated a package?

  4. kevmoo commented on Dec 1, 2023

    @kevmoo
    ContributorAuthor

    Tests pass with dart2wasm? We are almost there w/ pkg:test

  5. ditman commented on Dec 6, 2023

    @ditman
    Member

    No, actually this required some pretty major revisiting :P

    @kevmoo how do I run tests with dart2wasm?

  6. github-actions commented on Dec 21, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    e: wasmIssues related to the wasm build of Flutter Web.p: google_identity_services_webA JS-interop layer for Google Identity's Sign In With Google SDKpackageflutter/packages repository. See also p: labels.platform-webWeb applications specificallyteam-webOwned by Web platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions