Repository navigation
[google_sign_in] Remove guava dependency #13991
Description
This is no bugreport, more a question.
I started editing the google sign in plugin for android and figured out several problem, I would like to fix.
In order to do so, I would like to know what the getToken method is used for. According to the rest of the implementation, you can get the token out of the GoogleSignInAccount after a successful login. IMHO this method is not necessary, but I guess there's a reason for you to have it in there.
If not, I would like to remove it, since it's not really required and the dependency required (guava) is a method limit killer, since guava comes with about 15k methods
If it is needed for some reason, I created an alternative implementation without the guava dependency using android build in tools. See the PR mentioned below
Activity
mravn-google commentedon Jan 17, 2018
@collinjackson Why do we need the get tokens functionality?
thehitechpanky commentedon Aug 10, 2019
escamoteur commentedon Sep 25, 2019
@andretietz did you get further with that?
andretietz commentedon Oct 1, 2019
Sorry, I accidentially deleted my fork a while ago already, so I wasn't able to finish it. Since I am not on this atm, I havn't had the time to actually do the small changes. May be I'll create this PR once again, but I am not sure when I will have time to do so. I recommend doing it yourself, considering the small change proposals, which where made by @mravn-google
a6e8906 Roll src/third_party/dart 5b5f34f2e6..603fd7881f (11 commits) (…
TahaTesser commentedon Mar 16, 2020
Hi @andretietz
Is this issue still valid?
Thank you
noelmansour commentedon Mar 17, 2020
Not OP, but this is definitely still an issue. Guava is still included as a dependency in the plugin's build.gradle: https://github.com/flutter/plugins/blob/ad6fd0d0408bfd3a2f0d422f77015c789cb6bd95/packages/google_sign_in/google_sign_in/android/build.gradle#L38
Perhaps, the issue should be renamed to "Guava library should be removed". Someone else filed a separate issue for this here #41296, but it's the same core issue
serendipity1004 commentedon Mar 19, 2020
[-][Plugin google_sign_in] getToken[/-][+][google_sign_in] Remove guava dependency [/+]11 remaining items
[google_sign_in] Adopt task queues for Android (flutter#8622)
github-actions commentedon Mar 4, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[google_sign_in] Adopt task queues for Android (flutter#8622)
[google_sign_in] Adopt task queues for Android (flutter#8622)
[google_sign_in] Adopt task queues for Android (flutter#8622)
[google_sign_in] Adopt task queues for Android (flutter#8622)