Repository navigation
Repurpose dev/integration_tests/external_ui #142006
Description
/cc @jonahwilliams @johnmccutchan @bdero
Background
Unbeknown to me, we have an e2e test in the framework covering surface_texture external textures:
.ci.yaml:Line 2171 in e593cdf
.dartrunner:- (actual test) https://github.com/flutter/flutter/blob/e593cdfb80975fb6a41dff21e3f4f774f7e68723/dev/integration_tests/external_ui/test_driver/main_test.dart
If working properly, it produces a picture like this:
... however, it doesn't do any pixel validation, and only runs on the Skia backend.
Tasks
- Add a pixel-validation test, likely with two filled rectangles one-inside another
- Add a resizing platform view test (Manually revert TLHC optimizations, holding on to width/height changes. flutter-team-archive/engine#50144)
- Run Android in both Skia (current) and Impeller+OpenGLES (perhaps later in Vulkan)
- Rename
external_uitoexternal_texture_integration_testto disambiguate - Link to this test in the
shell/embedder/android/README.md
Activity
[-]Repurpose `dev/integration_tests/external_ui` as `android_surface_texture_integration_test`[/-][+]Repurpose `dev/integration_tests/external_ui`[/+]matanlurey commentedon Oct 7, 2024
I've decided to just not touch this for the time being.
github-actions commentedon Oct 21, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.