Skip to content

Re-land: Refactor external_ui → external_textures #142178

Closed
#143544
Closed
Re-land: Refactor external_ui → external_textures#142178
#143544
Assignees
matanlurey
Labels
P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@matanlurey
matanlurey
opened on Jan 24, 2024

#142062 was reverted. Example of builder failure:

2024-01-24 13:06:08.707419] [STDOUT] stdout: [  +17 ms] "flutter drive" took 20,989ms.
[2024-01-24 13:06:08.713860] [STDOUT] stderr: [   +4 ms] Target file "lib/main.dart" not found.
[2024-01-24 13:06:08.714128] [STDOUT] stderr: [   +1 ms] 
[2024-01-24 13:06:08.714185] [STDOUT] stderr:            #0      FlutterCommand.validateCommand (package:flutter_tools/src/runner/flutter_command.dart:1858:9)

Let's re-land this in phases:

  • Add README.md and tweak the lib and test directory (refactor, and local renames)
  • Add a bringup task called external_textures
  • Swap the tasks and remove external_ui

Activity

  1. matanlurey
    added
    P1High-priority issues at the top of the work list
    c: tech-debtTechnical debt, code quality, testing, etc.
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    on Jan 24, 2024
  2. matanlurey
    self-assigned this
    on Jan 24, 2024
  3. matanlurey
    added 2 commits that reference this issue on Jan 25, 2024

    Refactor `external_ui` without making any name changes (I think) (#14…

    b3da19f

    Rename `integration_tests/external_ui` but do not touch anything else…

    f61d2f5
  4. auto-submit
    added 3 commits that reference this issue on Jan 25, 2024

    Reverts "Rename `integration_tests/external_ui` but do not touch anyt…

    f8544df

    Reverts "Reverts "Rename `integration_tests/external_ui` but do not t…

    db25540

    Start renaming by adding a new `bringup: true` as an Android emulator. (

    2f6fdf2
  5. auto-submit
    added a commit that references this issue on Feb 13, 2024

    Rename `external_ui` to `external_textures`. (#143406)

    56387c0
  6. auto-submit
    closed this as completedin #143544on Feb 15, 2024
  7. auto-submit
    added a commit that references this issue on Feb 15, 2024

    Swap the tasks that have been running fine for a while. (#143544)

    7082ae1

  8. github-actions commented on Feb 29, 2024

    @github-actions
    github-actionsbot
    on Feb 29, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions