Repository navigation
ListWheelViewport should set needsCompositing #14224
Description
In the example https://github.com/xster/flutter-test/blob/master/t71_text_transform_rendering_2/lib/main.dart
TransformLayers without text works. canvas.transform works. But TransformLayers with text no longer works.
Activity
jason-simmons commentedon Jan 23, 2018
This was introduced when we stopped applying a cull rectangle to the PaintingContext's canvas:
0434ae2
The transform will render correctly if you revert to constructing
new Canvas(_recorder, estimatedBounds)in PaintingContext._startRecordingxster commentedon Jan 23, 2018
Thanks for the hint. I'm not super sure what what the instructive is from the RenderObject's perspective. The PaintingContext is already created.
Is there a way to re-assert using canvas's bounds once the PaintingContext is already created (before it was provided to the RenderObject.paint)?
Hixie commentedon Jan 25, 2018
That's weird. Bug in skia?
xster commentedon Jan 25, 2018
Tried on tip of skia and messed around a bit but couldn't figure it out.
https://bugs.chromium.org/p/skia/issues/detail?id=7537
xster commentedon Mar 16, 2018
This issue is no longer reproducible on head. Closing.
xster commentedon Mar 28, 2018
The issue reappeared on skia head. Follow-up in https://bugs.chromium.org/p/skia/issues/detail?id=7537
xster commentedon Mar 29, 2018
Seems to have broken between engine e61bb9a and 3e877d3
jason-simmons commentedon Mar 29, 2018
This bug was reintroduced by flutter-team-archive/engine@c9da000
That commit replaces an SkCanvas::save()/restore() with an equivalent translate/untranslate in order to work around another Skia bug (see https://bugs.chromium.org/p/skia/issues/detail?id=7739)
jslavitz commentedon Oct 25, 2018
@xster Looks like this works now!
xster commentedon Oct 25, 2018
Cool. Must have been fixed upstream. We should change https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/rendering/list_wheel_viewport.dart#L896 to
needsCompositingthen close this issue.[-]TransformLayers doesn't work on text[/-][+]ListWheelViewport should set needsCompositing[/+]LongCatIsLooong commentedon Mar 6, 2020
The issue should be fixed on master, despite having a visual glitch: #41654. Closing
github-actions commentedon Aug 16, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.