Skip to content

[web] Flutter test suite in the web needs love. #143124

Closed

Description

@ditman

While investigating this revert, a couple of concerning things were discovered wrt the Flutter test suite in the web.

  1. The revert was caused because some tests failed when the scene of the HTML renderer started respecting the "overridden" value of devicePixelRatio to report its "logical size".

  2. The devicePixelRatio overridden by flutter tests (3.0) does NOT match the devicePixelRatio set by the browser when it starts.

    • In fact, the browser is starting always with DPR=1. It should pass '--force-device-scale-factor=X' for other DPRs.
  3. By hijacking the _matchers_web.dart file, it seems that the isCanvasKit boolean used there to determine how to match a golden never returns true (this might be a regression) Fixed by: Pass along web renderer into debugging options in the test command. #143128


TL;DR: The flutter test runner needs some love in the flutter/flutter repository.

Activity

  1. changed the title [-][web] Flutter test suite in the web is concerning.[/-] [+][web] Flutter test suite in the web needs love.[/+] on Feb 7, 2024
  2. added
    in triagePresently being triaged by the triage team
    a: tests"flutter test", flutter_test, or one of our tests
    platform-webWeb applications specifically
    toolAffects the "flutter" command-line tool. See also t: labels.
    team-webOwned by Web platform team
    and removed
    in triagePresently being triaged by the triage team
    on Feb 8, 2024
  3. added
    P2Important issues not at the top of the work list
    triaged-webTriaged by Web platform team
    on Feb 8, 2024
  4. github-actions commented on Sep 23, 2026

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsplatform-webWeb applications specificallyteam-webOwned by Web platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-webTriaged by Web platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions