Repository navigation
[url_launcher] Replace deprecated renderView #143449
Description
'renderView' is deprecated and shouldn't be used. Consider using
RendererBinding.renderViews instead as the binding may manage multiple RenderViews. This feature was
deprecated after v3.10.0-12.0.pre. Try replacing the use of the deprecated member with the replacement.
I'm not sure if this is in 3.10 or 3.13 from the message; currently it's test-only code, so we could wait until 3.13 is our min-min version to fix this, since test-only fixes don't need to spread through the client ecosystem.
Activity
stuartmorgan-g commentedon Feb 15, 2024
Looks like
url_launcheris already 3.13-min.stuartmorgan-g commentedon Feb 15, 2024
We actually have a non-test usage of this as well, but it's not being flagged since it's in the deprecated
url_launcherAPI. I'm not sure there's much we can do other than delete that API to fix the use of the deprecated API, becauselaunchdoesn't have enough information to know which renderer to set the system UI overlay style for.The API was deprecated 22 months ago in 6.1.0, so I think removing it at this point is reasonable. There are >800 published packages depending on
url_launcherthough, so there's still the potential for some ecosystem effects.stuartmorgan-g commentedon Feb 15, 2024
After some more investigation through the API surface, there's a way to get best-effort backwards compatible behavior that will fall back to a no-op in the worst case, using non-deprecated APIs, so I'll do that to avoid a breaking change at this point.
[url_launcher] Remove `renderView` usage
stuartmorgan-g commentedon Feb 21, 2024
Looks like it's actually 3.16, but since it's not test-only after all I'm going to drop 3.13 for this.
[url_launcher] Remove `renderView` usage (#6137)
github-actions commentedon Mar 6, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[url_launcher] Remove `renderView` usage (flutter#6137)
[url_launcher] Remove `renderView` usage (flutter#6137)