Skip to content

_MergingListenable should use an Iterable #143664

Closed

Description

@TimeLex

Use case

The _MergingListenable in change_notifier.dart uses a List to store its children. If the constructor is called with an Iterable for the children, it must be converted to a List unnecessarily.

Proposal

The type of _MergingListenable._children should be changed to Iterable<Listenable?>, as it is only used for iteration through for-loops.

Activity

  1. added
    in triagePresently being triaged by the triage team
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Feb 19, 2024
  2. added
    P3Issues that are less important to the Flutter project
    on Feb 20, 2024
  3. added a commit that references this issue on Feb 26, 2024
    7b5ec58
  4. github-actions commented on Mar 12, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions